archive/php-src
1
0
Fork 0
mirror of https://github.com/php/php-src.git synced 2025-08-15 21:48:51 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

Remove useless operations in namespace_compat (#18182)

Browse source 
We never use the return value, so we can avoid a double lookup and a
return.
This commit is contained in:
Niels Dossche 2025-03-29 22:46:18 +01:00 • committed by GitHub
parent d456d25a1c
commit 0733e453c7
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 2 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

11
ext/dom/namespace_compat.c
View file

@ -180,7 +180,7 @@ PHP_DOM_EXPORT xmlNsPtr php_dom_libxml_ns_mapper_get_ns_raw_strings_nullsafe(php
return php_dom_libxml_ns_mapper_get_ns_raw_strings(mapper, prefix, uri);
}
static xmlNsPtr php_dom_libxml_ns_mapper_store_and_normalize_parsed_ns(php_dom_libxml_ns_mapper *mapper, xmlNsPtr ns)
static void php_dom_libxml_ns_mapper_store_and_normalize_parsed_ns(php_dom_libxml_ns_mapper *mapper, xmlNsPtr ns)
{
ZEND_ASSERT(ns != NULL);
@ -198,16 +198,9 @@ static xmlNsPtr php_dom_libxml_ns_mapper_store_and_normalize_parsed_ns(php_dom_l
prefix_len = xmlStrlen(ns->prefix);
}
zval *zv = zend_hash_str_find_ptr(prefix_map, prefix, prefix_len);
if (zv != NULL) {
return Z_PTR_P(zv);
}
zval new_zv;
DOM_Z_UNOWNED(&new_zv, ns);
zend_hash_str_add_new(prefix_map, prefix, prefix_len, &new_zv);
return ns;
zend_hash_str_add(prefix_map, prefix, prefix_len, &new_zv);
}
typedef struct {