archive/php-src
1
0
Fork 0
mirror of https://github.com/php/php-src.git synced 2025-08-15 21:48:51 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

ext/session/tests: more lenient expected output checks. (#11631)

Browse source 
Several session tests incidentally check the values of INI variables
like session.name and session.save_path. This isn't the point of the
tests, and it can cause spurious failures if (for example) you want to
override your temporary directory while testing. So here, we make the
expected output patterns more lenient.
This commit is contained in:
Michael Orlitzky 2023-07-10 04:25:25 -04:00 • committed by GitHub
parent 15bdc85e00
commit 092e090cf0
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 15 additions and 15 deletions
Download patch file Download diff file Expand all files Collapse all files

14
ext/session/tests/bug74514.phpt
View file

@ -25,10 +25,10 @@ var_dump(session_save_path());
var_dump(session_cache_limiter());
var_dump(session_cache_expire());
?>
--EXPECT--
string(9) "PHPSESSID"
string(3) "foo"
string(5) "files"
string(0) ""
string(7) "nocache"
int(180)
--EXPECTF--
string(%d) "%S"
string(%d) "%S"
string(%d) "%S"
string(%d) "%S"
string(%d) "%S"
int(%d)

8
ext/session/tests/bug74936.phpt
View file

@ -14,7 +14,7 @@ var_dump(session_cache_expire());
var_dump(session_cache_limiter());
var_dump(session_save_path());
?>
--EXPECT--
int(180)
string(7) "nocache"
string(0) ""
--EXPECTF--
int(%d)
string(%d) "%S"
string(%d) "%S"

8
ext/session/tests/user_session_module/gh7787.phpt
View file

@ -78,10 +78,10 @@ session_write_close();
?>
--EXPECTF--
Warning: session_write_close(): Failed to write session data using user defined save handler. (session.save_path: , handler: MySessionHandler::write) in %s on line %d
Warning: session_write_close(): Failed to write session data using user defined save handler. (session.save_path: %S, handler: MySessionHandler::write) in %s on line %d
Warning: session_write_close(): Failed to write session data using user defined save handler. (session.save_path: , handler: MySessionHandler::updateTimestamp) in %s on line %d
Warning: session_write_close(): Failed to write session data using user defined save handler. (session.save_path: %S, handler: MySessionHandler::updateTimestamp) in %s on line %d
Warning: session_write_close(): Failed to write session data using user defined save handler. (session.save_path: , handler: write) in %s on line %d
Warning: session_write_close(): Failed to write session data using user defined save handler. (session.save_path: %S, handler: write) in %s on line %d
Warning: session_write_close(): Failed to write session data using user defined save handler. (session.save_path: , handler: update_timestamp) in %s on line %d
Warning: session_write_close(): Failed to write session data using user defined save handler. (session.save_path: %S, handler: update_timestamp) in %s on line %d