archive/php-src
1
0
Fork 0
mirror of https://github.com/php/php-src.git synced 2025-08-15 13:38:49 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

Merge branch 'PHP-7.4'

Browse source 
* PHP-7.4:
  Fixed bug #79115
This commit is contained in:
Nikita Popov 2020-01-17 11:38:18 +01:00
commit 117b18d22d
2 changed files with 18 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

2
ext/reflection/php_reflection.c
View file

@ -4604,6 +4604,8 @@ ZEND_METHOD(reflection_class, isCloneable)
if (UNEXPECTED(object_init_ex(&obj, ce) != SUCCESS)) { if (UNEXPECTED(object_init_ex(&obj, ce) != SUCCESS)) {
return; return;
} }
/* We're not calling the constructor, so don't call the destructor either. */
zend_object_store_ctor_failed(Z_OBJ(obj));
RETVAL_BOOL(Z_OBJ_HANDLER(obj, clone_obj) != NULL); RETVAL_BOOL(Z_OBJ_HANDLER(obj, clone_obj) != NULL);
zval_ptr_dtor(&obj); zval_ptr_dtor(&obj);
} }

16
ext/reflection/tests/bug79115.phpt Normal file
View file

@ -0,0 +1,16 @@
--TEST--
Bug #79115: ReflectionClass::isCloneable call reflected class __destruct
--FILE--
<?php
class A {
function __construct() { echo __FUNCTION__ . "\n"; }
function __destruct() { echo __FUNCTION__ . "\n"; }
}
$c = new ReflectionClass('A');
var_dump($c->isCloneable());
?>
--EXPECT--
bool(true)