archive/php-src
1
0
Fork 0
mirror of https://github.com/php/php-src.git synced 2025-08-19 08:49:28 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

Fixed possible GLOBALS variable override when register_globals are ON.

Browse source 
Fixed possible register_globals toggle via parse_str().
This commit is contained in:
Ilia Alshanetsky 2005-09-28 22:31:29 +00:00
parent c775c4cf83
commit 146517684d
2 changed files with 11 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

7
main/php_variables.c
View file

@ -118,6 +118,13 @@ PHPAPI void php_register_variable_ex(char *var, zval *val, zval *track_vars_arra
zval_dtor(val);
return;
}
/* GLOBALS hijack attempt, reject parameter */
if (symtable1 == EG(active_symbol_table) && !strcmp("GLOBALS", var)) {
zval_dtor(val);
return;
}
/* ensure that we don't have spaces or dots in the variable name (not binary safe) */
for (p=var; *p; p++) {
switch (*p) {