From 15547a2eb1eb7f2afa5bafaeb667f85b0c279f07 Mon Sep 17 00:00:00 2001 From: Daniel Scherzer Date: Wed, 14 May 2025 12:57:24 -0400 Subject: [PATCH] gen_stub: simplify `generateFunctionEntries()` --- build/gen_stub.php | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/build/gen_stub.php b/build/gen_stub.php index a6fe91e1e81..6870b976d4f 100755 --- a/build/gen_stub.php +++ b/build/gen_stub.php @@ -5321,19 +5321,13 @@ function generateFunctionEntries(?Name $className, array $funcInfos, ?string $co return ''; } - $code = "\n"; - - if ($cond) { - $code .= "#if {$cond}\n"; - } - $functionEntryName = "ext_functions"; if ($className) { $underscoreName = implode("_", $className->getParts()); $functionEntryName = "class_{$underscoreName}_methods"; } - $code .= "static const zend_function_entry {$functionEntryName}[] = {\n"; + $code = "\nstatic const zend_function_entry {$functionEntryName}[] = {\n"; $code .= generateCodeWithConditions($funcInfos, "", static function (FuncInfo $funcInfo) { return $funcInfo->getFunctionEntry(); }, $cond); @@ -5341,7 +5335,7 @@ function generateFunctionEntries(?Name $className, array $funcInfos, ?string $co $code .= "};\n"; if ($cond) { - $code .= "#endif\n"; + $code = "\n#if {$cond}{$code}#endif\n"; } return $code;