From 18d07065c0ee63e60dc74b1d877c38271df91f05 Mon Sep 17 00:00:00 2001 From: Felipe Pena Date: Mon, 11 Aug 2008 00:47:45 +0000 Subject: [PATCH] - MFH: Fixed bug #45765 (ReflectionObject with default parameters of self::xxx cause an error) --- ext/reflection/php_reflection.c | 2 +- ext/reflection/tests/bug45765.phpt | 82 ++++++++++++++++++++++++++++++ 2 files changed, 83 insertions(+), 1 deletion(-) create mode 100644 ext/reflection/tests/bug45765.phpt diff --git a/ext/reflection/php_reflection.c b/ext/reflection/php_reflection.c index 0654bcbd28c..5d669b865bf 100644 --- a/ext/reflection/php_reflection.c +++ b/ext/reflection/php_reflection.c @@ -642,7 +642,7 @@ static void _parameter_string(string *str, zend_function *fptr, struct _zend_arg *zv = precv->op2.u.constant; zval_copy_ctor(zv); INIT_PZVAL(zv); - zval_update_constant(&zv, (void*)1 TSRMLS_CC); + zval_update_constant_ex(&zv, (void*)1, fptr->common.scope TSRMLS_CC); if (Z_TYPE_P(zv) == IS_BOOL) { if (Z_LVAL_P(zv)) { string_write(str, "true", sizeof("true")-1); diff --git a/ext/reflection/tests/bug45765.phpt b/ext/reflection/tests/bug45765.phpt new file mode 100644 index 00000000000..b0c1be2c4c8 --- /dev/null +++ b/ext/reflection/tests/bug45765.phpt @@ -0,0 +1,82 @@ +--TEST-- +Fixed bug #45765 (ReflectionObject with default parameters of self::xxx cause an error) +--FILE-- + +--EXPECTF-- +Object of class [ class foo extends foo2 ] { + @@ %s 7-21 + + - Constants [1] { + Constant [ string BAR ] { foo's bar } + } + + - Static properties [0] { + } + + - Static methods [0] { + } + + - Properties [0] { + } + + - Dynamic properties [0] { + } + + - Methods [4] { + Method [ public method test ] { + @@ %s 10 - 11 + + - Parameters [1] { + Parameter #0 [ $a = 'foo's bar' ] + } + } + + Method [ public method test2 ] { + @@ %s 13 - 14 + + - Parameters [1] { + Parameter #0 [ $a = 'foobar' ] + } + } + + Method [ public method test3 ] { + @@ %s 16 - 17 + + - Parameters [1] { + Parameter #0 [ $a = 'foo's bar' ] + } + } + + Method [ public method test4 ] { + @@ %s 19 - 20 + + - Parameters [1] { + Parameter #0 [ $a = 'foobar' ] + } + } + } +}