archive/php-src
1
0
Fork 0
mirror of https://github.com/php/php-src.git synced 2025-08-16 05:58:45 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

0 byte file uploads are valid, avoid choking on them

Browse source
This commit is contained in:
Zeev Suraski 2002-05-11 11:58:16 +00:00
parent 70f72d0568
commit 19b7861d70
1 changed files with 5 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

8
main/rfc1867.c
View file

@ -33,6 +33,8 @@
#include "rfc1867.h" #include "rfc1867.h"
#undef DEBUG_FILE_UPLOAD
#define SAFE_RETURN { \ #define SAFE_RETURN { \
if (lbuf) efree(lbuf); \ if (lbuf) efree(lbuf); \
if (abuf) efree(abuf); \ if (abuf) efree(abuf); \
@ -752,19 +754,19 @@ SAPI_API SAPI_POST_HANDLER_FUNC(rfc1867_post_handler)
} }
fclose(fp); fclose(fp);
#ifdef DEBUG_FILE_UPLOAD
if(strlen(filename) > 0 && total_bytes == 0) { if(strlen(filename) > 0 && total_bytes == 0) {
sapi_module.sapi_error(E_WARNING, "Uploaded file size 0 - file [%s=%s] not saved", param, filename); sapi_module.sapi_error(E_WARNING, "Uploaded file size 0 - file [%s=%s] not saved", param, filename);
cancel_upload = UPLOAD_ERROR_E; cancel_upload = UPLOAD_ERROR_E;
} }
#endif
if (cancel_upload || total_bytes == 0) { if (cancel_upload) {
if (temp_filename) { if (temp_filename) {
unlink(temp_filename); unlink(temp_filename);
efree(temp_filename); efree(temp_filename);
} }
temp_filename=""; temp_filename="";
} else { } else {
zend_hash_add(SG(rfc1867_uploaded_files), temp_filename, strlen(temp_filename) + 1, &temp_filename, sizeof(char *), NULL); zend_hash_add(SG(rfc1867_uploaded_files), temp_filename, strlen(temp_filename) + 1, &temp_filename, sizeof(char *), NULL);
} }