From 1a61d29d5dc368058ee66b286ae94bb5702015c2 Mon Sep 17 00:00:00 2001 From: Niels Dossche <7771979+nielsdos@users.noreply.github.com> Date: Sun, 29 Dec 2024 15:52:23 +0100 Subject: [PATCH] Use zend_new_pair --- ext/simplexml/simplexml.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/ext/simplexml/simplexml.c b/ext/simplexml/simplexml.c index 7f801f2fdd6..f9ea7cea07b 100644 --- a/ext/simplexml/simplexml.c +++ b/ext/simplexml/simplexml.c @@ -956,17 +956,13 @@ static void sxe_properties_add(HashTable *rv, char *name, int namelen, zval *val { zend_string *key; zval *data_ptr; - zval newptr; key = zend_string_init(name, namelen, 0); if ((data_ptr = zend_hash_find(rv, key)) != NULL) { if (Z_TYPE_P(data_ptr) == IS_ARRAY) { zend_hash_next_index_insert_new(Z_ARRVAL_P(data_ptr), value); } else { - array_init(&newptr); - zend_hash_next_index_insert_new(Z_ARRVAL(newptr), data_ptr); - zend_hash_next_index_insert_new(Z_ARRVAL(newptr), value); - ZVAL_ARR(data_ptr, Z_ARR(newptr)); + ZVAL_ARR(data_ptr, zend_new_pair(data_ptr, value)); } } else { zend_hash_add_new(rv, key, value);