archive/php-src
1
0
Fork 0
mirror of https://github.com/php/php-src.git synced 2025-08-16 05:58:45 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

ext/bcmath: Removed unnecessary zero padding (#14134)

Browse source 
bc_num is initialized to 0 by `memset`, so there is no need to write it to 0.
This commit is contained in:
Saki Takamachi 2024-05-05 00:03:08 +09:00 • committed by GitHub
parent a728e541e9
commit 1ae58d4784
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 0 additions and 16 deletions
Download patch file Download diff file Expand all files Collapse all files

16
ext/bcmath/libbcmath/src/doaddsub.c
View file

@ -51,14 +51,6 @@ bc_num _bc_do_add(bc_num n1, bc_num n2, size_t scale_min)
sum_digits = MAX (n1->n_len, n2->n_len) + 1;
sum = bc_new_num (sum_digits, MAX(sum_scale, scale_min));
/* Zero extra digits made by scale_min. */
if (scale_min > sum_scale) {
sumptr = (char *) (sum->n_value + sum_scale + sum_digits);
for (int count = scale_min - sum_scale; count > 0; count--) {
*sumptr++ = 0;
}
}
/* Start with the fraction part. Initialize the pointers. */
n1bytes = n1->n_scale;
n2bytes = n2->n_scale;
@ -145,14 +137,6 @@ bc_num _bc_do_sub(bc_num n1, bc_num n2, size_t scale_min)
min_scale = MIN(n1->n_scale, n2->n_scale);
diff = bc_new_num (diff_len, MAX(diff_scale, scale_min));
/* Zero extra digits made by scale_min. */
if (scale_min > diff_scale) {
diffptr = (char *) (diff->n_value + diff_len + diff_scale);
for (count = scale_min - diff_scale; count > 0; count--) {
*diffptr++ = 0;
}
}
/* Initialize the subtract. */
n1ptr = (char *) (n1->n_value + n1->n_len + n1->n_scale - 1);
n2ptr = (char *) (n2->n_value + n2->n_len + n2->n_scale - 1);