add error check and fix leak

This commit is contained in:
Anatol Belski 2016-08-29 17:25:46 +02:00
parent 7ecfb4b954
commit 201f90a8cc

View file

@ -753,9 +753,14 @@ PHP_FUNCTION(proc_open)
len = (sizeof(COMSPEC_NT) + sizeof(" /c ") + tmp_len + 1);
cmdw2 = (wchar_t *)malloc(len * sizeof(wchar_t));
if (!cmdw2) {
php_error_docref(NULL, E_WARNING, "Command conversion failed");
goto exit_fail;
}
ret = _snwprintf(cmdw2, len, L"%hs /c %s", COMSPEC_NT, cmdw);
if (-1 == ret) {
free(cmdw2);
php_error_docref(NULL, E_WARNING, "Command conversion failed");
goto exit_fail;
}