From 248b5f5b0ff2f2337caebc14be22cedf8b6077e3 Mon Sep 17 00:00:00 2001 From: Niels Dossche <7771979+nielsdos@users.noreply.github.com> Date: Tue, 2 Apr 2024 18:17:21 +0200 Subject: [PATCH] Remove useless NULL-check in phpdbg_print (#13853) &method->op_array cannot possibly be NULL because it takes a pointer to a field of method. --- sapi/phpdbg/phpdbg_print.c | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/sapi/phpdbg/phpdbg_print.c b/sapi/phpdbg/phpdbg_print.c index c28576de3bc..b0f8d4cb294 100644 --- a/sapi/phpdbg/phpdbg_print.c +++ b/sapi/phpdbg/phpdbg_print.c @@ -55,15 +55,13 @@ static inline void phpdbg_print_function_helper(zend_function *method) /* {{{ */ case ZEND_USER_FUNCTION: { zend_op_array* op_array = &(method->op_array); - if (op_array) { - zend_dump_op_array(op_array, ZEND_DUMP_LINE_NUMBERS, NULL, NULL); + zend_dump_op_array(op_array, ZEND_DUMP_LINE_NUMBERS, NULL, NULL); - for (uint32_t i = 0; i < op_array->num_dynamic_func_defs; i++) { - zend_op_array *def = op_array->dynamic_func_defs[i]; - phpdbg_out("\ndynamic def: %i, function name: %.*s\n", - i, (int) ZSTR_LEN(def->function_name), ZSTR_VAL(def->function_name)); - zend_dump_op_array(def, ZEND_DUMP_LINE_NUMBERS, NULL, NULL); - } + for (uint32_t i = 0; i < op_array->num_dynamic_func_defs; i++) { + zend_op_array *def = op_array->dynamic_func_defs[i]; + phpdbg_out("\ndynamic def: %i, function name: %.*s\n", + i, (int) ZSTR_LEN(def->function_name), ZSTR_VAL(def->function_name)); + zend_dump_op_array(def, ZEND_DUMP_LINE_NUMBERS, NULL, NULL); } } break;