archive/php-src
1
0
Fork 0
mirror of https://github.com/php/php-src.git synced 2025-08-16 05:58:45 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

Fix php cli (-S option) inconsistent port parsing

Browse source 
Add port range verification of listening port with -S option for the php cli.
This fixes inconsistent listening port due to unverified cast from long to short
with htons(3).
This commit is contained in:
nil0x42 2014-07-11 19:48:03 +02:00 • committed by Stanislav Malyshev
parent cb1a297bf4
commit 2a73d56ef9
1 changed files with 2 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

4
sapi/cli/php_cli_server.c
View file

@ -2256,7 +2256,7 @@ static int php_cli_server_ctor(php_cli_server *server, const char *addr, const c
*p++ = '\0'; *p++ = '\0';
if (*p == ':') { if (*p == ':') {
port = strtol(p + 1, &p, 10); port = strtol(p + 1, &p, 10);
if (port <= 0) { if (port <= 0 || port > 65535) {
p = NULL; p = NULL;
} }
} else if (*p != '\0') { } else if (*p != '\0') {
@ -2272,7 +2272,7 @@ static int php_cli_server_ctor(php_cli_server *server, const char *addr, const c
if (p) { if (p) {
*p++ = '\0'; *p++ = '\0';
port = strtol(p, &p, 10); port = strtol(p, &p, 10);
if (port <= 0) { if (port <= 0 || port > 65535) {
p = NULL; p = NULL;
} }
} }