archive/php-src
1
0
Fork 0
mirror of https://github.com/php/php-src.git synced 2025-08-16 05:58:45 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

Better return types for getBackingType (#8687)

Browse source 
The only backing types for Enums are int and string. The proper return type for ReflectionEnum::getBackingType() is thus null|ReflectionNamedType.

See also https://github.com/php/doc-en/pull/1608

Closes GH-8687
This commit is contained in:
Sam 2022-06-02 18:13:21 +02:00 • committed by GitHub
parent eb022f8071
commit 2ce2aff50e
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 6 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

2
NEWS
View file

@ -55,6 +55,8 @@ PHP NEWS
- Reflection: - Reflection:
. Added ReflectionFunction::isAnonymous(). (Nicolas Grekas) . Added ReflectionFunction::isAnonymous(). (Nicolas Grekas)
. Added ReflectionMethod::hasPrototype(). (Ollie Read) . Added ReflectionMethod::hasPrototype(). (Ollie Read)
. Narrow ReflectionEnum::getBackingType() return type to ReflectionNamedType.
(SamMousa)
- Session: - Session:
. Fixed bug GH-7787 (Improve session write failure message for user error . Fixed bug GH-7787 (Improve session write failure message for user error

2
ext/reflection/php_reflection.stub.php
View file

@ -729,7 +729,7 @@ class ReflectionEnum extends ReflectionClass
public function isBacked(): bool {} public function isBacked(): bool {}
public function getBackingType(): ?ReflectionType {} public function getBackingType(): ?ReflectionNamedType {}
} }
class ReflectionEnumUnitCase extends ReflectionClassConstant class ReflectionEnumUnitCase extends ReflectionClassConstant

5
ext/reflection/php_reflection_arginfo.h
View file

@ -1,5 +1,5 @@
/* This is a generated file, edit the .stub.php file instead. /* This is a generated file, edit the .stub.php file instead.
* Stub hash: 4191864554b030bea40306c0d30090a8e2c76ab2 */ * Stub hash: 9daec020902840b7f678d787e61e91f7e16ad4da */
ZEND_BEGIN_ARG_WITH_TENTATIVE_RETURN_TYPE_INFO_EX(arginfo_class_Reflection_getModifierNames, 0, 1, IS_ARRAY, 0) ZEND_BEGIN_ARG_WITH_TENTATIVE_RETURN_TYPE_INFO_EX(arginfo_class_Reflection_getModifierNames, 0, 1, IS_ARRAY, 0)
ZEND_ARG_TYPE_INFO(0, modifiers, IS_LONG, 0) ZEND_ARG_TYPE_INFO(0, modifiers, IS_LONG, 0)
@ -568,7 +568,8 @@ ZEND_END_ARG_INFO()
#define arginfo_class_ReflectionEnum_isBacked arginfo_class_ReflectionFunctionAbstract_hasTentativeReturnType #define arginfo_class_ReflectionEnum_isBacked arginfo_class_ReflectionFunctionAbstract_hasTentativeReturnType
#define arginfo_class_ReflectionEnum_getBackingType arginfo_class_ReflectionFunctionAbstract_getTentativeReturnType ZEND_BEGIN_ARG_WITH_RETURN_OBJ_INFO_EX(arginfo_class_ReflectionEnum_getBackingType, 0, 0, ReflectionNamedType, 1)
ZEND_END_ARG_INFO()
#define arginfo_class_ReflectionEnumUnitCase___construct arginfo_class_ReflectionClassConstant___construct #define arginfo_class_ReflectionEnumUnitCase___construct arginfo_class_ReflectionClassConstant___construct