archive/php-src
1
0
Fork 0
mirror of https://github.com/php/php-src.git synced 2025-08-15 13:38:49 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

Merge branch 'PHP-8.4'

Browse source 
* PHP-8.4:
  Extract call_level conditions out to separate functions (#16949)
This commit is contained in:
Niels Dossche 2024-11-26 21:23:59 +01:00
commit 30ec2de83f
No known key found for this signature in database
GPG key ID: B8A8AD166DF0E2E5
2 changed files with 51 additions and 77 deletions
Download patch file Download diff file Expand all files Collapse all files

77
ext/opcache/jit/zend_jit.c
View file

@ -836,6 +836,38 @@ ZEND_EXT_API void zend_jit_status(zval *ret)
add_assoc_zval(ret, "jit", &stats); add_assoc_zval(ret, "jit", &stats);
} }
static bool zend_jit_inc_call_level(uint8_t opcode)
{
switch (opcode) {
case ZEND_INIT_FCALL:
case ZEND_INIT_FCALL_BY_NAME:
case ZEND_INIT_NS_FCALL_BY_NAME:
case ZEND_INIT_METHOD_CALL:
case ZEND_INIT_DYNAMIC_CALL:
case ZEND_INIT_STATIC_METHOD_CALL:
case ZEND_INIT_PARENT_PROPERTY_HOOK_CALL:
case ZEND_INIT_USER_CALL:
case ZEND_NEW:
return true;
default:
return false;
}
}
static bool zend_jit_dec_call_level(uint8_t opcode)
{
switch (opcode) {
case ZEND_DO_FCALL:
case ZEND_DO_ICALL:
case ZEND_DO_UCALL:
case ZEND_DO_FCALL_BY_NAME:
case ZEND_CALLABLE_CONVERT:
return true;
default:
return false;
}
}
static zend_string *zend_jit_func_name(const zend_op_array *op_array) static zend_string *zend_jit_func_name(const zend_op_array *op_array)
{ {
smart_str buf = {0}; smart_str buf = {0};
@ -1572,17 +1604,8 @@ static int zend_jit(const zend_op_array *op_array, zend_ssa *ssa, const zend_op
for (i = ssa->cfg.blocks[b].start; i <= end; i++) { for (i = ssa->cfg.blocks[b].start; i <= end; i++) {
zend_ssa_op *ssa_op = ssa->ops ? &ssa->ops[i] : NULL; zend_ssa_op *ssa_op = ssa->ops ? &ssa->ops[i] : NULL;
opline = op_array->opcodes + i; opline = op_array->opcodes + i;
switch (opline->opcode) { if (zend_jit_inc_call_level(opline->opcode)) {
case ZEND_INIT_FCALL: call_level++;
case ZEND_INIT_FCALL_BY_NAME:
case ZEND_INIT_NS_FCALL_BY_NAME:
case ZEND_INIT_METHOD_CALL:
case ZEND_INIT_DYNAMIC_CALL:
case ZEND_INIT_STATIC_METHOD_CALL:
case ZEND_INIT_PARENT_PROPERTY_HOOK_CALL:
case ZEND_INIT_USER_CALL:
case ZEND_NEW:
call_level++;
} }
if (JIT_G(opt_level) >= ZEND_JIT_LEVEL_INLINE) { if (JIT_G(opt_level) >= ZEND_JIT_LEVEL_INLINE) {
@ -2720,25 +2743,10 @@ static int zend_jit(const zend_op_array *op_array, zend_ssa *ssa, const zend_op
i++; i++;
for (; i < end; i++) { for (; i < end; i++) {
opline = op_array->opcodes + i; opline = op_array->opcodes + i;
switch (opline->opcode) { if (zend_jit_inc_call_level(opline->opcode)) {
case ZEND_INIT_FCALL: call_level++;
case ZEND_INIT_FCALL_BY_NAME: } else if (zend_jit_dec_call_level(opline->opcode)) {
case ZEND_INIT_NS_FCALL_BY_NAME: call_level--;
case ZEND_INIT_METHOD_CALL:
case ZEND_INIT_DYNAMIC_CALL:
case ZEND_INIT_STATIC_METHOD_CALL:
case ZEND_INIT_PARENT_PROPERTY_HOOK_CALL:
case ZEND_INIT_USER_CALL:
case ZEND_NEW:
call_level++;
break;
case ZEND_DO_FCALL:
case ZEND_DO_ICALL:
case ZEND_DO_UCALL:
case ZEND_DO_FCALL_BY_NAME:
case ZEND_CALLABLE_CONVERT:
call_level--;
break;
} }
} }
opline = op_array->opcodes + i; opline = op_array->opcodes + i;
@ -2853,13 +2861,8 @@ static int zend_jit(const zend_op_array *op_array, zend_ssa *ssa, const zend_op
} }
} }
done: done:
switch (opline->opcode) { if (zend_jit_dec_call_level(opline->opcode)) {
case ZEND_DO_FCALL: call_level--;
case ZEND_DO_ICALL:
case ZEND_DO_UCALL:
case ZEND_DO_FCALL_BY_NAME:
case ZEND_CALLABLE_CONVERT:
call_level--;
} }
} }
zend_jit_bb_end(&ctx, b); zend_jit_bb_end(&ctx, b);

51
ext/opcache/jit/zend_jit_trace.c
View file

@ -1164,28 +1164,13 @@ static const zend_op *zend_jit_trace_find_init_fcall_op(zend_jit_trace_rec *p, c
if (opline) { if (opline) {
while (opline > op_array->opcodes) { while (opline > op_array->opcodes) {
opline--; opline--;
switch (opline->opcode) { if (zend_jit_inc_call_level(opline->opcode)) {
case ZEND_INIT_FCALL: if (call_level == 0) {
case ZEND_INIT_FCALL_BY_NAME: return opline;
case ZEND_INIT_NS_FCALL_BY_NAME: }
case ZEND_INIT_METHOD_CALL: call_level--;
case ZEND_INIT_DYNAMIC_CALL: } else if (zend_jit_dec_call_level(opline->opcode)) {
case ZEND_INIT_STATIC_METHOD_CALL: call_level++;
case ZEND_INIT_PARENT_PROPERTY_HOOK_CALL:
case ZEND_INIT_USER_CALL:
case ZEND_NEW:
if (call_level == 0) {
return opline;
}
call_level--;
break;
case ZEND_DO_FCALL:
case ZEND_DO_ICALL:
case ZEND_DO_UCALL:
case ZEND_DO_FCALL_BY_NAME:
case ZEND_CALLABLE_CONVERT:
call_level++;
break;
} }
} }
} }
@ -4422,17 +4407,8 @@ static const void *zend_jit_trace(zend_jit_trace_rec *trace_buffer, uint32_t par
frame_flags = 0; frame_flags = 0;
switch (opline->opcode) { if (zend_jit_inc_call_level(opline->opcode)) {
case ZEND_INIT_FCALL: frame->call_level++;
case ZEND_INIT_FCALL_BY_NAME:
case ZEND_INIT_NS_FCALL_BY_NAME:
case ZEND_INIT_METHOD_CALL:
case ZEND_INIT_DYNAMIC_CALL:
case ZEND_INIT_STATIC_METHOD_CALL:
case ZEND_INIT_PARENT_PROPERTY_HOOK_CALL:
case ZEND_INIT_USER_CALL:
case ZEND_NEW:
frame->call_level++;
} }
if (JIT_G(opt_level) >= ZEND_JIT_LEVEL_INLINE) { if (JIT_G(opt_level) >= ZEND_JIT_LEVEL_INLINE) {
@ -6497,13 +6473,8 @@ static const void *zend_jit_trace(zend_jit_trace_rec *trace_buffer, uint32_t par
done: done:
polymorphic_side_trace = 0; polymorphic_side_trace = 0;
switch (opline->opcode) { if (zend_jit_dec_call_level(opline->opcode)) {
case ZEND_DO_FCALL: frame->call_level--;
case ZEND_DO_ICALL:
case ZEND_DO_UCALL:
case ZEND_DO_FCALL_BY_NAME:
case ZEND_CALLABLE_CONVERT:
frame->call_level--;
} }
if (ra) { if (ra) {