archive/php-src
1
0
Fork 0
mirror of https://github.com/php/php-src.git synced 2025-08-16 05:58:45 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

Remove restriction on method call inlining

Browse source 
In PHP 8, we are guaranteed that $this exists, so we no longer have
to forbid this case.
This commit is contained in:
Nikita Popov 2020-06-29 09:54:31 +02:00
parent bc62acf874
commit 315ea609da
1 changed files with 0 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

7
ext/opcache/Optimizer/optimize_func_calls.c
View file

@ -113,13 +113,6 @@ static void zend_try_inline_call(zend_op_array *op_array, zend_op *fcall, zend_o
return; return;
} }
if (fcall->opcode == ZEND_INIT_METHOD_CALL && fcall->op1_type == IS_UNUSED) {
/* TODO: we can't inlne methods, because $this may be used
* not in object context ???
*/
return;
}
for (i = 0; i < num_args; i++) { for (i = 0; i < num_args; i++) {
/* Don't inline functions with by-reference arguments. This would require /* Don't inline functions with by-reference arguments. This would require
* correct handling of INDIRECT arguments. */ * correct handling of INDIRECT arguments. */