archive/php-src
1
0
Fork 0
mirror of https://github.com/php/php-src.git synced 2025-08-15 21:48:51 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

base64_decode: Handle all invalid padding equally

Browse source
This commit is contained in:
Lauri Kenttä 2016-07-11 12:40:10 +03:00 • committed by Nikita Popov
parent 5c62f3f68e
commit 316d5a19a6
1 changed files with 0 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

5
ext/standard/base64.c
View file

@ -149,11 +149,6 @@ PHPAPI zend_string *php_base64_decode_ex(const unsigned char *str, size_t length
break;
}
if (ch == base64_pad) {
/* fail if the padding character is second in a group (like V===) */
/* FIXME: why do we still allow invalid padding in other places in the middle of the string? */
if (i % 4 == 1) {
goto fail;
}
padding++;
continue;
}