archive/php-src
1
0
Fork 0
mirror of https://github.com/php/php-src.git synced 2025-08-15 21:48:51 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

Avoid unnecessary destruction in bc_mul()

Browse source
This commit is contained in:
Niels Dossche 2024-05-01 21:14:03 +02:00
parent 0cd952d851
commit 34b2116eb5
8 changed files with 21 additions and 18 deletions
Download patch file Download diff file Expand all files Collapse all files

6
ext/bcmath/bcmath.c
View file

@ -242,7 +242,7 @@ PHP_FUNCTION(bcmul)
zend_string *left, *right;
zend_long scale_param;
bool scale_param_is_null = 1;
bc_num first = NULL, second = NULL, result;
bc_num first = NULL, second = NULL, result = NULL;
int scale;
ZEND_PARSE_PARAMETERS_START(2, 3)
@ -261,8 +261,6 @@ PHP_FUNCTION(bcmul)
scale = (int) scale_param;
}
bc_init_num(&result);
if (php_str2num(&first, ZSTR_VAL(left)) == FAILURE) {
zend_argument_value_error(1, "is not well-formed");
goto cleanup;
@ -273,7 +271,7 @@ PHP_FUNCTION(bcmul)
goto cleanup;
}
bc_multiply (first, second, &result, scale);
result = bc_multiply (first, second, scale);
RETVAL_NEW_STR(bc_num2str_ex(result, scale));