Voidify zend_ssa_compute_use_def_chains()

It always returned SUCCESS
This commit is contained in:
George Peter Banyard 2021-09-20 18:24:40 +01:00
parent 25deb7d254
commit 35dfdd9b1b
4 changed files with 4 additions and 10 deletions

View file

@ -89,9 +89,7 @@ zend_result zend_dfa_analyze_op_array(zend_op_array *op_array, zend_optimizer_ct
} }
if (zend_ssa_compute_use_def_chains(&ctx->arena, op_array, ssa) != SUCCESS){ zend_ssa_compute_use_def_chains(&ctx->arena, op_array, ssa);
return FAILURE;
}
zend_ssa_find_false_dependencies(op_array, ssa); zend_ssa_find_false_dependencies(op_array, ssa);

View file

@ -1043,7 +1043,7 @@ ZEND_API zend_result zend_build_ssa(zend_arena **arena, const zend_script *scrip
} }
/* }}} */ /* }}} */
ZEND_API int zend_ssa_compute_use_def_chains(zend_arena **arena, const zend_op_array *op_array, zend_ssa *ssa) /* {{{ */ ZEND_API void zend_ssa_compute_use_def_chains(zend_arena **arena, const zend_op_array *op_array, zend_ssa *ssa) /* {{{ */
{ {
zend_ssa_var *ssa_vars; zend_ssa_var *ssa_vars;
int i; int i;
@ -1158,8 +1158,6 @@ ZEND_API int zend_ssa_compute_use_def_chains(zend_arena **arena, const zend_op_a
ssa_vars[i].alias = ssa_vars[ssa_vars[i].var].alias; ssa_vars[i].alias = ssa_vars[ssa_vars[i].var].alias;
} }
} }
return SUCCESS;
} }
/* }}} */ /* }}} */

View file

@ -146,7 +146,7 @@ typedef struct _zend_ssa {
BEGIN_EXTERN_C() BEGIN_EXTERN_C()
ZEND_API zend_result zend_build_ssa(zend_arena **arena, const zend_script *script, const zend_op_array *op_array, uint32_t build_flags, zend_ssa *ssa); ZEND_API zend_result zend_build_ssa(zend_arena **arena, const zend_script *script, const zend_op_array *op_array, uint32_t build_flags, zend_ssa *ssa);
ZEND_API int zend_ssa_compute_use_def_chains(zend_arena **arena, const zend_op_array *op_array, zend_ssa *ssa); ZEND_API void zend_ssa_compute_use_def_chains(zend_arena **arena, const zend_op_array *op_array, zend_ssa *ssa);
ZEND_API int zend_ssa_rename_op(const zend_op_array *op_array, const zend_op *opline, uint32_t k, uint32_t build_flags, int ssa_vars_count, zend_ssa_op *ssa_ops, int *var); ZEND_API int zend_ssa_rename_op(const zend_op_array *op_array, const zend_op *opline, uint32_t k, uint32_t build_flags, int ssa_vars_count, zend_ssa_op *ssa_ops, int *var);
int zend_ssa_unlink_use_chain(zend_ssa *ssa, int op, int var); int zend_ssa_unlink_use_chain(zend_ssa *ssa, int op, int var);

View file

@ -1315,9 +1315,7 @@ static int zend_jit_op_array_analyze1(const zend_op_array *op_array, zend_script
return FAILURE; return FAILURE;
} }
if (zend_ssa_compute_use_def_chains(&CG(arena), op_array, ssa) != SUCCESS) { zend_ssa_compute_use_def_chains(&CG(arena), op_array, ssa);
return FAILURE;
}
zend_ssa_find_false_dependencies(op_array, ssa); zend_ssa_find_false_dependencies(op_array, ssa);