archive/php-src
1
0
Fork 0
mirror of https://github.com/php/php-src.git synced 2025-08-15 13:38:49 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

Minor cleanup in dom_character_data_append_data (#15173)

Browse source
This commit is contained in:
Niels Dossche 2024-07-30 23:05:12 +02:00 • committed by GitHub
parent ceca599649
commit 3c68661ec9
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 5 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

14
ext/dom/characterdata.c
View file

@ -154,34 +154,30 @@ PHP_METHOD(DOMCharacterData, substringData)
Modern spec URL: https://dom.spec.whatwg.org/#dom-characterdata-appenddata Modern spec URL: https://dom.spec.whatwg.org/#dom-characterdata-appenddata
Since: Since:
*/ */
static void dom_character_data_append_data(INTERNAL_FUNCTION_PARAMETERS, bool return_true) static void dom_character_data_append_data(INTERNAL_FUNCTION_PARAMETERS)
{ {
zval *id;
xmlNode *nodep; xmlNode *nodep;
dom_object *intern; dom_object *intern;
char *arg; char *arg;
size_t arg_len; size_t arg_len;
id = ZEND_THIS;
if (zend_parse_parameters(ZEND_NUM_ARGS(), "s", &arg, &arg_len) == FAILURE) { if (zend_parse_parameters(ZEND_NUM_ARGS(), "s", &arg, &arg_len) == FAILURE) {
RETURN_THROWS(); RETURN_THROWS();
} }
DOM_GET_OBJ(nodep, id, xmlNodePtr, intern); DOM_GET_OBJ(nodep, ZEND_THIS, xmlNodePtr, intern);
xmlTextConcat(nodep, BAD_CAST arg, arg_len); xmlTextConcat(nodep, BAD_CAST arg, arg_len);
if (return_true) {
RETURN_TRUE;
}
} }
PHP_METHOD(DOMCharacterData, appendData) PHP_METHOD(DOMCharacterData, appendData)
{ {
dom_character_data_append_data(INTERNAL_FUNCTION_PARAM_PASSTHRU, true); dom_character_data_append_data(INTERNAL_FUNCTION_PARAM_PASSTHRU);
RETURN_TRUE;
} }
PHP_METHOD(Dom_CharacterData, appendData) PHP_METHOD(Dom_CharacterData, appendData)
{ {
dom_character_data_append_data(INTERNAL_FUNCTION_PARAM_PASSTHRU, false); dom_character_data_append_data(INTERNAL_FUNCTION_PARAM_PASSTHRU);
} }
/* }}} end dom_characterdata_append_data */ /* }}} end dom_characterdata_append_data */