archive/php-src
1
0
Fork 0
mirror of https://github.com/php/php-src.git synced 2025-08-16 05:58:45 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

Fix bug pointed out in feature request 81268

Browse source 
The error message which is generated when one tries to assign null to an intersection type property is wrong and misleading
This commit is contained in:
George Peter Banyard 2021-07-17 01:39:29 +02:00
parent edb6b375dd
commit 3cfcfacd36
2 changed files with 13 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

12
Zend/tests/type_declarations/intersection_types/bug81268.phpt Normal file
View file

@ -0,0 +1,12 @@
--TEST--
Bug #81268 Wrong message when using null as a default value for intersection types
--FILE--
<?php
class Test {
public X&Y $y = null;
}
?>
--EXPECTF--
Fatal error: Cannot use null as default value for property Test::$y of type X&Y in %s on line %d

2
Zend/zend_compile.c
View file

@ -7324,7 +7324,7 @@ void zend_compile_prop_decl(zend_ast *ast, zend_ast *type_ast, uint32_t flags, z
if (ZEND_TYPE_IS_SET(type) && !Z_CONSTANT(value_zv)
&& !zend_is_valid_default_value(type, &value_zv)) {
zend_string *str = zend_type_to_string(type);
if (Z_TYPE(value_zv) == IS_NULL) {
if (Z_TYPE(value_zv) == IS_NULL && !ZEND_TYPE_IS_INTERSECTION(type)) {
ZEND_TYPE_FULL_MASK(type) |= MAY_BE_NULL;
zend_string *nullable_str = zend_type_to_string(type);