archive/php-src
1
0
Fork 0
mirror of https://github.com/php/php-src.git synced 2025-08-15 13:38:49 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

Make documentURI and URL not readonly (#13982)

Browse source 
These aren't actually readonly right now because `@readonly` means
nothing, and the setters are configured in php_dom.c. So no functional
changes here.

DOM spec marks these as readonly, but the problem is that this reduces
usefulness in XML contexts (like WSDL scheme handling). In context of a
browser, for which DOM was designed, this actually makes sense to have
as readonly because it is tied to the origin of the page etc. But PHP is
not a browser. This also wasn't readonly in "old DOM".
This commit is contained in:
Niels Dossche 2024-04-17 17:35:29 +02:00 • committed by GitHub
parent 58c0202506
commit 47ec32044e
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 1 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

2
ext/dom/php_dom.stub.php
View file

@ -1515,9 +1515,7 @@ namespace DOM
{
/** @readonly */
public Implementation $implementation;
/** @readonly */
public string $URL;
/** @readonly */
public string $documentURI;
public string $characterSet;
public string $charset;

2
ext/dom/php_dom_arginfo.h generated
View file

@ -1,5 +1,5 @@
/* This is a generated file, edit the .stub.php file instead.
* Stub hash: 37a1c811bfc8c611d686f0842d06fc327b54511f */
* Stub hash: 49a153db3d3aa28031d7a15c15f89f6f3e9c33a5 */
ZEND_BEGIN_ARG_WITH_RETURN_OBJ_INFO_EX(arginfo_dom_import_simplexml, 0, 1, DOMElement, 0)
ZEND_ARG_TYPE_INFO(0, node, IS_OBJECT, 0)