archive/php-src
1
0
Fork 0
mirror of https://github.com/php/php-src.git synced 2025-08-15 21:48:51 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

Avoid useless checks, using zend_string_efree(), in cases where the string is known to be a temporary allocated zend_string.

Browse source
This commit is contained in:
Dmitry Stogov 2018-05-08 17:30:15 +03:00
parent 9565075cbd
commit 524f5245c5
36 changed files with 176 additions and 168 deletions
Download patch file Download diff file Expand all files Collapse all files

4
main/php_variables.c
View file

@ -600,7 +600,7 @@ PHPAPI void php_build_argv(char *s, zval *track_vars_array)
for (i = 0; i < SG(request_info).argc; i++) {
ZVAL_STRING(&tmp, SG(request_info).argv[i]);
if (zend_hash_next_index_insert(Z_ARRVAL(arr), &tmp) == NULL) {
zend_string_free(Z_STR(tmp));
zend_string_efree(Z_STR(tmp));
}
}
} else if (s && *s) {
@ -614,7 +614,7 @@ PHPAPI void php_build_argv(char *s, zval *track_vars_array)
ZVAL_STRING(&tmp, ss);
count++;
if (zend_hash_next_index_insert(Z_ARRVAL(arr), &tmp) == NULL) {
zend_string_free(Z_STR(tmp));
zend_string_efree(Z_STR(tmp));
}
if (space) {
*space = '+';