archive/php-src
1
0
Fork 0
mirror of https://github.com/php/php-src.git synced 2025-08-16 05:58:45 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

Merge branch 'PHP-7.4'

Browse source 
* PHP-7.4:
  Fix #79806: realpath() erroneously resolves link to link
This commit is contained in:
Christoph M. Becker 2020-07-27 15:11:39 +02:00
commit 54e15dcd6f
2 changed files with 12 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

14
Zend/zend_virtual_cwd.c
View file

@ -590,6 +590,7 @@ static size_t tsrm_realpath_r(char *path, size_t start, size_t len, int *ll, tim
} }
#ifdef ZEND_WIN32 #ifdef ZEND_WIN32
retry_reparse_point:
if (save) { if (save) {
pathw = php_win32_ioutil_any_to_w(path); pathw = php_win32_ioutil_any_to_w(path);
if (!pathw) { if (!pathw) {
@ -612,7 +613,7 @@ static size_t tsrm_realpath_r(char *path, size_t start, size_t len, int *ll, tim
tmp = do_alloca(len+1, use_heap); tmp = do_alloca(len+1, use_heap);
memcpy(tmp, path, len+1); memcpy(tmp, path, len+1);
retry: retry_reparse_tag_cloud:
if(save && if(save &&
!(IS_UNC_PATH(path, len) && len >= 3 && path[2] != '?') && !(IS_UNC_PATH(path, len) && len >= 3 && path[2] != '?') &&
(dataw.dwFileAttributes & FILE_ATTRIBUTE_REPARSE_POINT) (dataw.dwFileAttributes & FILE_ATTRIBUTE_REPARSE_POINT)
@ -673,7 +674,7 @@ retry:
dataw.dwFileAttributes = fileInformation.dwFileAttributes; dataw.dwFileAttributes = fileInformation.dwFileAttributes;
CloseHandle(hLink); CloseHandle(hLink);
(*ll)--; (*ll)--;
goto retry; goto retry_reparse_tag_cloud;
} }
free_alloca(tmp, use_heap); free_alloca(tmp, use_heap);
CloseHandle(hLink); CloseHandle(hLink);
@ -820,6 +821,15 @@ retry:
free_alloca(pbuffer, use_heap_large); free_alloca(pbuffer, use_heap_large);
free(substitutename); free(substitutename);
{
DWORD attrs = GetFileAttributesA(path);
if (!isVolume && (attrs & FILE_ATTRIBUTE_REPARSE_POINT)) {
free_alloca(tmp, use_heap);
FREE_PATHW()
goto retry_reparse_point;
}
}
if(isabsolute == 1) { if(isabsolute == 1) {
if (!((j == 3) && (path[1] == ':') && (path[2] == '\\'))) { if (!((j == 3) && (path[1] == ':') && (path[2] == '\\'))) {
/* use_realpath is 0 in the call below coz path is absolute*/ /* use_realpath is 0 in the call below coz path is absolute*/

6
ext/standard/tests/file/realpath_basic4.phpt
View file

@ -1,11 +1,5 @@
--TEST-- --TEST--
Test realpath() with relative paths Test realpath() with relative paths
--SKIPIF--
<?php
if (substr(PHP_OS, 0, 3) == 'WIN') {
die('skip not for Windows');
}
?>
--FILE-- --FILE--
<?php <?php
$file_path = __DIR__; $file_path = __DIR__;