mirror of
https://github.com/php/php-src.git
synced 2025-08-16 05:58:45 +02:00
- Warning fixes by Steph
This commit is contained in:
parent
84fc80064b
commit
5a69b29082
17 changed files with 36 additions and 36 deletions
|
@ -178,7 +178,7 @@ static inline zval *_get_zval_ptr_var(znode *node, temp_variable *Ts, zend_free_
|
|||
|
||||
if (T->str_offset.str->type != IS_STRING
|
||||
|| ((int)T->str_offset.offset < 0)
|
||||
|| (T->str_offset.str->value.str.len <= T->str_offset.offset)) {
|
||||
|| (T->str_offset.str->value.str.len <= (int)T->str_offset.offset)) {
|
||||
zend_error(E_NOTICE, "Uninitialized string offset: %d", T->str_offset.offset);
|
||||
ptr->value.str.val = STR_EMPTY_ALLOC();
|
||||
ptr->value.str.len = 0;
|
||||
|
@ -658,7 +658,7 @@ static inline void zend_assign_to_variable(znode *result, znode *op1, znode *op2
|
|||
zend_error(E_WARNING, "Illegal string offset: %d", T->str_offset.offset);
|
||||
break;
|
||||
}
|
||||
if (T->str_offset.offset >= T->str_offset.str->value.str.len) {
|
||||
if ((int)T->str_offset.offset >= T->str_offset.str->value.str.len) {
|
||||
zend_uint i;
|
||||
|
||||
if (T->str_offset.str->value.str.len==0) {
|
||||
|
|
|
@ -482,7 +482,7 @@ ZEND_API int zval_update_constant(zval **pp, void *arg TSRMLS_DC)
|
|||
continue;
|
||||
}
|
||||
|
||||
if (const_value.type == IS_STRING && const_value.value.str.len == str_index_len-1 &&
|
||||
if (const_value.type == IS_STRING && const_value.value.str.len == (int)str_index_len-1 &&
|
||||
!strncmp(const_value.value.str.val, str_index, str_index_len)) {
|
||||
/* constant value is the same as its name */
|
||||
zval_dtor(&const_value);
|
||||
|
|
|
@ -336,7 +336,7 @@ static int zend_implement_aggregate(zend_class_entry *interface, zend_class_entr
|
|||
} else if (class_type->get_iterator != zend_user_it_get_new_iterator) {
|
||||
/* c-level get_iterator cannot be changed (exception being only Traversable is implmented) */
|
||||
if (class_type->num_interfaces) {
|
||||
for (i = 0; i < class_type->num_interfaces; i++) {
|
||||
for (i = 0; i < (int)class_type->num_interfaces; i++) {
|
||||
if (class_type->interfaces[i] == zend_ce_iterator) {
|
||||
return FAILURE;
|
||||
}
|
||||
|
|
|
@ -3096,7 +3096,7 @@ ZEND_VM_HANDLER(78, ZEND_FE_FETCH, VAR, ANY)
|
|||
HashTable *fe_ht;
|
||||
zend_object_iterator *iter = NULL;
|
||||
int key_type;
|
||||
zend_bool use_key = opline->extended_value & ZEND_FE_FETCH_WITH_KEY;
|
||||
zend_bool use_key = (zend_bool)(opline->extended_value & ZEND_FE_FETCH_WITH_KEY);
|
||||
|
||||
PZVAL_LOCK(array);
|
||||
|
||||
|
|
|
@ -7561,7 +7561,7 @@ static int ZEND_FE_FETCH_SPEC_VAR_HANDLER(ZEND_OPCODE_HANDLER_ARGS)
|
|||
HashTable *fe_ht;
|
||||
zend_object_iterator *iter = NULL;
|
||||
int key_type;
|
||||
zend_bool use_key = opline->extended_value & ZEND_FE_FETCH_WITH_KEY;
|
||||
zend_bool use_key = (zend_bool)(opline->extended_value & ZEND_FE_FETCH_WITH_KEY);
|
||||
|
||||
PZVAL_LOCK(array);
|
||||
|
||||
|
|
|
@ -355,7 +355,7 @@ PHPAPI char *php_reg_replace(const char *pattern, const char *replace, const cha
|
|||
new_l = strlen(buf) + subs[0].rm_so; /* part before the match */
|
||||
walk = replace;
|
||||
while (*walk) {
|
||||
if ('\\' == *walk && isdigit((unsigned char)walk[1]) && ((unsigned char)walk[1]) - '0' <= re.re_nsub) {
|
||||
if ('\\' == *walk && isdigit((unsigned char)walk[1]) && ((unsigned char)walk[1]) - '0' <= (int)re.re_nsub) {
|
||||
if (subs[walk[1] - '0'].rm_so > -1 && subs[walk[1] - '0'].rm_eo > -1) {
|
||||
new_l += subs[walk[1] - '0'].rm_eo - subs[walk[1] - '0'].rm_so;
|
||||
}
|
||||
|
|
|
@ -1810,13 +1810,13 @@ HashTable* php_splice(HashTable *in_hash, int offset, int length,
|
|||
/* Clamp the offset.. */
|
||||
if (offset > num_in)
|
||||
offset = num_in;
|
||||
else if (offset < 0 && (offset=num_in+offset) < 0)
|
||||
else if (offset < 0 && (offset = (num_in + offset)) < 0)
|
||||
offset = 0;
|
||||
|
||||
/* ..and the length */
|
||||
if (length < 0) {
|
||||
length = num_in - offset + length;
|
||||
} else if (((unsigned) offset + (unsigned) length) > num_in) {
|
||||
} else if (((unsigned)offset + (unsigned)length) > (unsigned)num_in) {
|
||||
length = num_in - offset;
|
||||
}
|
||||
|
||||
|
@ -2204,13 +2204,13 @@ PHP_FUNCTION(array_slice)
|
|||
/* Clamp the offset.. */
|
||||
if (offset_val > num_in)
|
||||
return;
|
||||
else if (offset_val < 0 && (offset_val=num_in+offset_val) < 0)
|
||||
else if (offset_val < 0 && (offset_val = (num_in + offset_val)) < 0)
|
||||
offset_val = 0;
|
||||
|
||||
/* ..and the length */
|
||||
if (length_val < 0) {
|
||||
length_val = num_in - offset_val + length_val;
|
||||
} else if (((unsigned) offset_val + (unsigned) length_val) > num_in) {
|
||||
} else if (((unsigned)offset_val + (unsigned)length_val) > (unsigned)num_in) {
|
||||
length_val = num_in - offset_val;
|
||||
}
|
||||
|
||||
|
|
|
@ -370,7 +370,7 @@ PHP_FUNCTION(glob)
|
|||
int pattern_len;
|
||||
long flags = 0;
|
||||
glob_t globbuf;
|
||||
unsigned int n;
|
||||
int n;
|
||||
int ret;
|
||||
|
||||
if (zend_parse_parameters(ZEND_NUM_ARGS() TSRMLS_CC, "s|l", &pattern, &pattern_len, &flags) == FAILURE)
|
||||
|
|
|
@ -135,7 +135,7 @@ int php_exec(int type, char *cmd, zval *array, zval *return_value TSRMLS_DC)
|
|||
/* strip trailing whitespaces */
|
||||
l = bufl;
|
||||
while (l-- && isspace(((unsigned char *)buf)[l]));
|
||||
if (l != (bufl - 1)) {
|
||||
if (l != (int)(bufl - 1)) {
|
||||
bufl = l + 1;
|
||||
buf[bufl] = '\0';
|
||||
}
|
||||
|
@ -148,7 +148,7 @@ int php_exec(int type, char *cmd, zval *array, zval *return_value TSRMLS_DC)
|
|||
if (type != 2) {
|
||||
l = bufl;
|
||||
while (l-- && isspace(((unsigned char *)buf)[l]));
|
||||
if (l != (bufl - 1)) {
|
||||
if (l != (int)(bufl - 1)) {
|
||||
bufl = l + 1;
|
||||
buf[bufl] = '\0';
|
||||
}
|
||||
|
|
|
@ -55,7 +55,7 @@
|
|||
#endif
|
||||
|
||||
#define INC_OUTPUTPOS(a,b) \
|
||||
if ((a) < 0 || ((INT_MAX - outputpos)/(b)) < (a)) { \
|
||||
if ((a) < 0 || ((INT_MAX - outputpos)/((int)b)) < (a)) { \
|
||||
php_error_docref(NULL TSRMLS_CC, E_WARNING, "Type %c: integer overflow in format string", code); \
|
||||
RETURN_FALSE; \
|
||||
} \
|
||||
|
|
|
@ -355,7 +355,7 @@ PHPAPI char *php_reg_replace(const char *pattern, const char *replace, const cha
|
|||
new_l = strlen(buf) + subs[0].rm_so; /* part before the match */
|
||||
walk = replace;
|
||||
while (*walk) {
|
||||
if ('\\' == *walk && isdigit((unsigned char)walk[1]) && ((unsigned char)walk[1]) - '0' <= re.re_nsub) {
|
||||
if ('\\' == *walk && isdigit((unsigned char)walk[1]) && ((unsigned char)walk[1]) - '0' <= (int)re.re_nsub) {
|
||||
if (subs[walk[1] - '0'].rm_so > -1 && subs[walk[1] - '0'].rm_eo > -1) {
|
||||
new_l += subs[walk[1] - '0'].rm_eo - subs[walk[1] - '0'].rm_so;
|
||||
}
|
||||
|
|
|
@ -237,7 +237,7 @@ static void php_spn_common_handler(INTERNAL_FUNCTION_PARAMETERS, int behavior)
|
|||
}
|
||||
}
|
||||
|
||||
if (((unsigned) start + (unsigned) len) > len1) {
|
||||
if ((start + len) > len1) {
|
||||
len = len1 - start;
|
||||
}
|
||||
|
||||
|
@ -1166,7 +1166,7 @@ quit_loop:
|
|||
if (state == 1) {
|
||||
cend = c;
|
||||
}
|
||||
if (suffix != NULL && sufflen < (cend - comp) &&
|
||||
if (suffix != NULL && sufflen < (uint)(cend - comp) &&
|
||||
memcmp(cend - sufflen, suffix, sufflen) == 0) {
|
||||
cend -= sufflen;
|
||||
}
|
||||
|
@ -1983,7 +1983,7 @@ PHP_FUNCTION(substr)
|
|||
RETURN_FALSE;
|
||||
}
|
||||
|
||||
if (((unsigned) f + (unsigned) l) > Z_STRLEN_PP(str)) {
|
||||
if ((f + l) > Z_STRLEN_PP(str)) {
|
||||
l = Z_STRLEN_PP(str) - f;
|
||||
}
|
||||
|
||||
|
@ -2080,7 +2080,7 @@ PHP_FUNCTION(substr_replace)
|
|||
}
|
||||
}
|
||||
|
||||
if (((unsigned) f + (unsigned) l) > Z_STRLEN_PP(str)) {
|
||||
if ((f + l) > Z_STRLEN_PP(str)) {
|
||||
l = Z_STRLEN_PP(str) - f;
|
||||
}
|
||||
if (Z_TYPE_PP(repl) == IS_ARRAY) {
|
||||
|
@ -2176,7 +2176,7 @@ PHP_FUNCTION(substr_replace)
|
|||
}
|
||||
}
|
||||
|
||||
if (((unsigned) f + (unsigned) l) > Z_STRLEN_PP(tmp_str)) {
|
||||
if ((f + l) > Z_STRLEN_PP(tmp_str)) {
|
||||
l = Z_STRLEN_PP(tmp_str) - f;
|
||||
}
|
||||
|
||||
|
|
|
@ -406,7 +406,7 @@ static void php_stream_bucket_attach(int append, INTERNAL_FUNCTION_PARAMETERS)
|
|||
if (!bucket->own_buf) {
|
||||
bucket = php_stream_bucket_make_writeable(bucket TSRMLS_CC);
|
||||
}
|
||||
if (bucket->buflen != Z_STRLEN_PP(pzdata)) {
|
||||
if ((int)bucket->buflen != Z_STRLEN_PP(pzdata)) {
|
||||
bucket->buf = perealloc(bucket->buf, Z_STRLEN_PP(pzdata), bucket->is_persistent);
|
||||
bucket->buflen = Z_STRLEN_PP(pzdata);
|
||||
}
|
||||
|
|
|
@ -659,7 +659,7 @@ static void php_error_cb(int type, const char *error_filename, const uint error_
|
|||
* be NULL if PG(last_error_message) is not NULL */
|
||||
if (strcmp(PG(last_error_message), buffer)
|
||||
|| (!PG(ignore_repeated_source)
|
||||
&& ((PG(last_error_lineno) != error_lineno)
|
||||
&& ((PG(last_error_lineno) != (int)error_lineno)
|
||||
|| strcmp(PG(last_error_file), error_filename)))) {
|
||||
display = 1;
|
||||
} else {
|
||||
|
|
|
@ -351,7 +351,7 @@ PHPAPI void _php_stream_filter_append(php_stream_filter_chain *chain, php_stream
|
|||
php_stream_bucket_append(brig_inp, bucket TSRMLS_CC);
|
||||
status = filter->fops->filter(stream, filter, brig_inp, brig_outp, &consumed, PSFS_FLAG_NORMAL TSRMLS_CC);
|
||||
|
||||
if (stream->readpos + consumed > stream->writepos || consumed < 0) {
|
||||
if (stream->readpos + consumed > (uint)stream->writepos || consumed < 0) {
|
||||
/* No behaving filter should cause this. */
|
||||
status = PSFS_ERR_FATAL;
|
||||
}
|
||||
|
|
|
@ -531,7 +531,7 @@ static int fcgi_read_request(fcgi_request *req)
|
|||
}
|
||||
len = p - buf - sizeof(fcgi_header);
|
||||
len += fcgi_make_header((fcgi_header*)buf, FCGI_GET_VALUES_RESULT, 0, len);
|
||||
if (safe_write(req, buf, sizeof(fcgi_header)+len) != sizeof(fcgi_header)+len) {
|
||||
if (safe_write(req, buf, sizeof(fcgi_header)+len) != (int)sizeof(fcgi_header)+len) {
|
||||
return 0;
|
||||
}
|
||||
return 0;
|
||||
|
|
|
@ -67,13 +67,13 @@ PHPAPI int php_select(int max_fd, fd_set *rfds, fd_set *wfds, fd_set *efds, stru
|
|||
if ((DWORD)handles[n_handles] == 0xffffffff) {
|
||||
/* socket */
|
||||
if (SAFE_FD_ISSET(i, rfds)) {
|
||||
FD_SET(i, &sock_read);
|
||||
FD_SET((uint)i, &sock_read);
|
||||
}
|
||||
if (SAFE_FD_ISSET(i, wfds)) {
|
||||
FD_SET(i, &sock_write);
|
||||
FD_SET((uint)i, &sock_write);
|
||||
}
|
||||
if (SAFE_FD_ISSET(i, efds)) {
|
||||
FD_SET(i, &sock_except);
|
||||
FD_SET((uint)i, &sock_except);
|
||||
}
|
||||
if (i > sock_max_fd) {
|
||||
sock_max_fd = i;
|
||||
|
@ -136,13 +136,13 @@ PHPAPI int php_select(int max_fd, fd_set *rfds, fd_set *wfds, fd_set *efds, stru
|
|||
for (i = 0; i < n_handles; i++) {
|
||||
if (WAIT_OBJECT_0 == WaitForSingleObject(handles[i], 0)) {
|
||||
if (SAFE_FD_ISSET(handle_slot_to_fd[i], rfds)) {
|
||||
FD_SET(handle_slot_to_fd[i], &aread);
|
||||
FD_SET((uint)handle_slot_to_fd[i], &aread);
|
||||
}
|
||||
if (SAFE_FD_ISSET(handle_slot_to_fd[i], wfds)) {
|
||||
FD_SET(handle_slot_to_fd[i], &awrite);
|
||||
FD_SET((uint)handle_slot_to_fd[i], &awrite);
|
||||
}
|
||||
if (SAFE_FD_ISSET(handle_slot_to_fd[i], efds)) {
|
||||
FD_SET(handle_slot_to_fd[i], &aexcept);
|
||||
FD_SET((uint)handle_slot_to_fd[i], &aexcept);
|
||||
}
|
||||
retcode++;
|
||||
}
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue