archive/php-src
1
0
Fork 0
mirror of https://github.com/php/php-src.git synced 2025-08-16 05:58:45 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

Fix memory leaks in pdo_sqlite callback registration

Browse source 
* We need to clean the trampoline if the construction check fails
* Checking for an exception and then returning causes a leak on
  `collation`. Returning early is pointless anyway.

Closes GH-17904.
This commit is contained in:
Niels Dossche 2025-02-23 15:06:07 +01:00
parent 76035090b6
commit 635fe263ac
No known key found for this signature in database
GPG key ID: B8A8AD166DF0E2E5
2 changed files with 8 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

14
ext/pdo_sqlite/sqlite_driver.c
View file

@ -513,7 +513,7 @@ void pdo_sqlite_create_function_internal(INTERNAL_FUNCTION_PARAMETERS)
ZEND_PARSE_PARAMETERS_END_EX(goto error;);
dbh = Z_PDO_DBH_P(ZEND_THIS);
PDO_CONSTRUCT_CHECK;
PDO_CONSTRUCT_CHECK_WITH_CLEANUP(error);
H = (pdo_sqlite_db_handle *)dbh->driver_data;
@ -571,7 +571,7 @@ void pdo_sqlite_create_aggregate_internal(INTERNAL_FUNCTION_PARAMETERS)
ZEND_PARSE_PARAMETERS_END_EX(goto error;);
dbh = Z_PDO_DBH_P(ZEND_THIS);
PDO_CONSTRUCT_CHECK;
PDO_CONSTRUCT_CHECK_WITH_CLEANUP(error);
H = (pdo_sqlite_db_handle *)dbh->driver_data;
@ -643,7 +643,7 @@ void pdo_sqlite_create_collation_internal(INTERNAL_FUNCTION_PARAMETERS, pdo_sqli
ZEND_PARSE_PARAMETERS_END();
dbh = Z_PDO_DBH_P(ZEND_THIS);
PDO_CONSTRUCT_CHECK;
PDO_CONSTRUCT_CHECK_WITH_CLEANUP(cleanup_fcc);
H = (pdo_sqlite_db_handle *)dbh->driver_data;
@ -663,12 +663,12 @@ void pdo_sqlite_create_collation_internal(INTERNAL_FUNCTION_PARAMETERS, pdo_sqli
zend_release_fcall_info_cache(&fcc);
if (UNEXPECTED(EG(exception))) {
RETURN_THROWS();
}
efree(collation);
RETURN_FALSE;
cleanup_fcc:
zend_release_fcall_info_cache(&fcc);
RETURN_THROWS();
}
/* {{{ bool SQLite::sqliteCreateCollation(string name, callable callback)