From 65f885738defe8c723e3d1131c0eb007cb71866d Mon Sep 17 00:00:00 2001 From: "Christoph M. Becker" Date: Mon, 21 Oct 2024 14:42:43 +0200 Subject: [PATCH] Drop useless retrieval of opened_path (GH-16522) There is no point in retrieving the real path, if we don't use it. --- ext/dba/dba.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/ext/dba/dba.c b/ext/dba/dba.c index d2b58c7a59e..67928864ad8 100644 --- a/ext/dba/dba.c +++ b/ext/dba/dba.c @@ -823,14 +823,10 @@ restart: } else { spprintf(&lock_name, 0, "%s.lck", ZSTR_VAL(connection->info->path)); if (!strcmp(file_mode, "r")) { - zend_string *opened_path = NULL; /* when in read only mode try to use existing .lck file first */ /* do not log errors for .lck file while in read only mode on .lck file */ lock_file_mode = "rb"; - connection->info->lock.fp = php_stream_open_wrapper(lock_name, lock_file_mode, STREAM_MUST_SEEK|IGNORE_PATH|persistent_flag, &opened_path); - if (opened_path) { - zend_string_release_ex(opened_path, 0); - } + connection->info->lock.fp = php_stream_open_wrapper(lock_name, lock_file_mode, STREAM_MUST_SEEK|IGNORE_PATH|persistent_flag, NULL); } if (!connection->info->lock.fp) { /* when not in read mode or failed to open .lck file read only. now try again in create(write) mode and log errors */