archive/php-src
1
0
Fork 0
mirror of https://github.com/php/php-src.git synced 2025-08-15 21:48:51 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

Fix GH-12727: NumberFormatter constructor throws an exception on invalid locale.

Browse source 
Also re-establishing exception throwing on IntlDateFormatter constructor
overwritten by accident most likely so postponing it for next major
release.

Close GH-12868
This commit is contained in:
David Carlier 2023-12-04 22:00:17 +00:00
parent d751e61504
commit 683e787860
7 changed files with 57 additions and 18 deletions
Download patch file Download diff file Expand all files Collapse all files

3
ext/intl/dateformat/dateformat_create.cpp
View file

@ -113,7 +113,8 @@ static zend_result datefmt_ctor(INTERNAL_FUNCTION_PARAMETERS, zend_error_handlin
locale = Locale::createFromName(locale_str);
/* get*Name accessors being set does not preclude being bogus */
if (locale.isBogus() || strlen(locale.getISO3Language()) == 0) {
goto error;
zend_argument_value_error(1, "\"%s\" is invalid", locale_str);
return FAILURE;
}
/* process calendar */