archive/php-src
1
0
Fork 0
mirror of https://github.com/php/php-src.git synced 2025-08-15 13:38:49 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

[RFC] Deprecate curl_share_close() (#19452)

Browse source 
https://wiki.php.net/rfc/deprecations_php_8_5
This commit is contained in:
Daniel Scherzer 2025-08-12 05:49:52 -07:00 • committed by GitHub
parent 9b13bb1ae4
commit 699e5632b1
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 12 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

1
ext/curl/curl.stub.php
View file

@ -3811,6 +3811,7 @@ function curl_setopt_array(CurlHandle $handle, array $options): bool {}
function curl_setopt(CurlHandle $handle, int $option, mixed $value): bool {}
#[\Deprecated(since: '8.5', message: "as it has no effect since PHP 8.0")]
function curl_share_close(CurlShareHandle $share_handle): void {}
function curl_share_errno(CurlShareHandle $share_handle): int {}

10
ext/curl/curl_arginfo.h generated
View file

@ -1,5 +1,5 @@
/* This is a generated file, edit the .stub.php file instead.
* Stub hash: 172dc89afccd670434ce2ca0a6c905c77edcf337 */
* Stub hash: 2a2772e99deea07c0bc148e9715e6a960230cf4d */
ZEND_BEGIN_ARG_WITH_RETURN_TYPE_INFO_EX(arginfo_curl_close, 0, 1, IS_VOID, 0)
ZEND_ARG_OBJ_INFO(0, handle, CurlHandle, 0)
@ -214,7 +214,7 @@ static const zend_function_entry ext_functions[] = {
ZEND_FE(curl_reset, arginfo_curl_reset)
ZEND_FE(curl_setopt_array, arginfo_curl_setopt_array)
ZEND_FE(curl_setopt, arginfo_curl_setopt)
ZEND_FE(curl_share_close, arginfo_curl_share_close)
ZEND_RAW_FENTRY("curl_share_close", zif_curl_share_close, arginfo_curl_share_close, ZEND_ACC_DEPRECATED, NULL, NULL)
ZEND_FE(curl_share_errno, arginfo_curl_share_errno)
ZEND_FE(curl_share_init, arginfo_curl_share_init)
ZEND_FE(curl_share_setopt, arginfo_curl_share_setopt)
@ -993,6 +993,12 @@ static void register_curl_symbols(int module_number)
ZVAL_STR(&attribute_Deprecated_func_curl_close_0->args[1].value, attribute_Deprecated_func_curl_close_0_arg1_str);
attribute_Deprecated_func_curl_close_0->args[1].name = ZSTR_KNOWN(ZEND_STR_MESSAGE);
zend_attribute *attribute_Deprecated_func_curl_share_close_0 = zend_add_function_attribute(zend_hash_str_find_ptr(CG(function_table), "curl_share_close", sizeof("curl_share_close") - 1), ZSTR_KNOWN(ZEND_STR_DEPRECATED_CAPITALIZED), 2);
ZVAL_STR(&attribute_Deprecated_func_curl_share_close_0->args[0].value, ZSTR_KNOWN(ZEND_STR_8_DOT_5));
attribute_Deprecated_func_curl_share_close_0->args[0].name = ZSTR_KNOWN(ZEND_STR_SINCE);
ZVAL_STR_COPY(&attribute_Deprecated_func_curl_share_close_0->args[1].value, attribute_Deprecated_func_curl_close_0_arg1_str);
attribute_Deprecated_func_curl_share_close_0->args[1].name = ZSTR_KNOWN(ZEND_STR_MESSAGE);
zend_attribute *attribute_Deprecated_const_CURLOPT_BINARYTRANSFER_0 = zend_add_global_constant_attribute(const_CURLOPT_BINARYTRANSFER, ZSTR_KNOWN(ZEND_STR_DEPRECATED_CAPITALIZED), 2);
ZVAL_STR(&attribute_Deprecated_const_CURLOPT_BINARYTRANSFER_0->args[0].value, ZSTR_KNOWN(ZEND_STR_8_DOT_4));
attribute_Deprecated_const_CURLOPT_BINARYTRANSFER_0->args[0].name = ZSTR_KNOWN(ZEND_STR_SINCE);

4
ext/curl/tests/curl_share_close_basic001.phpt
View file

@ -13,8 +13,10 @@ curl_share_close($sh);
var_dump($sh);
?>
--EXPECT--
--EXPECTF--
object(CurlShareHandle)#1 (0) {
}
Deprecated: Function curl_share_close() is deprecated since 8.5, as it has no effect since PHP 8.0 in %s on line %d
object(CurlShareHandle)#1 (0) {
}