archive/php-src
1
0
Fork 0
mirror of https://github.com/php/php-src.git synced 2025-08-16 05:58:45 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

Fix #79065: DOM classes do not expose properties to Reflection

Browse source 
We add a `get_properties` handler which complements the already
existing `has_property` and `read_property`handlers.
This commit is contained in:
Christoph M. Becker 2020-04-21 13:28:01 +02:00
parent a2ed731fa5
commit 6bc8f7e5a9
3 changed files with 55 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

2
NEWS
View file

@ -16,6 +16,8 @@ PHP NEWS
- DOM:
. Fixed bug #78221 (DOMNode::normalize() doesn't remove empty text nodes).
(cmb)
. Fixed bug #79065 (DOM classes do not expose properties to Reflection).
(cmb)
- EXIF:
. Fixed bug #79336 (ext/exif/tests/bug79046.phpt fails on Big endian arch).

23
ext/dom/php_dom.c
View file

@ -410,6 +410,28 @@ static int dom_property_exists(zval *object, zval *member, int check_empty, void
}
/* }}} */
/* {{{ dom_get_properties */
static HashTable *dom_get_properties(zval *object)
{
dom_object *obj = Z_DOMOBJ_P(object);
HashTable *props = zend_std_get_properties(object);
if (obj->prop_handler != NULL) {
zend_string *key;
dom_prop_handler *hnd;
ZEND_HASH_FOREACH_STR_KEY_PTR(obj->prop_handler, key, hnd) {
zval val;
if (hnd->read_func(obj, &val) == SUCCESS) {
zend_hash_update(props, key, &val);
}
} ZEND_HASH_FOREACH_END();
}
return props;
}
/* }}} */
static HashTable* dom_get_debug_info_helper(zval *object, int *is_temp) /* {{{ */
{
dom_object *obj = Z_DOMOBJ_P(object);
@ -602,6 +624,7 @@ PHP_MINIT_FUNCTION(dom)
dom_object_handlers.get_property_ptr_ptr = dom_get_property_ptr_ptr;
dom_object_handlers.clone_obj = dom_objects_store_clone_obj;
dom_object_handlers.has_property = dom_property_exists;
dom_object_handlers.get_properties = dom_get_properties;
dom_object_handlers.get_debug_info = dom_get_debug_info;
memcpy(&dom_nnodemap_object_handlers, &dom_object_handlers, sizeof(zend_object_handlers));

30
ext/dom/tests/bug79065.phpt Normal file
View file

@ -0,0 +1,30 @@
--TEST--
Bug #79065 (DOM classes do not expose properties to Reflection)
--SKIPIF--
<?php
if (!extension_loaded('dom')) die('skip dom extension not available');
?>
--FILE--
<?php
$dom = new DOMDocument;
$dom->loadHTML('<b>test</b>');
var_dump(count(get_object_vars($dom)));
$ro = new ReflectionObject($dom);
var_dump(count($ro->getProperties()));
var_dump($ro->hasProperty("textContent"));
$rp = $ro->getProperty("textContent");
var_dump($rp);
var_dump($rp->getValue($dom));
?>
--EXPECTF--
int(35)
int(35)
bool(true)
object(ReflectionProperty)#%d (2) {
["name"]=>
string(11) "textContent"
["class"]=>
string(11) "DOMDocument"
}
string(4) "test"