archive/php-src
1
0
Fork 0
mirror of https://github.com/php/php-src.git synced 2025-08-15 21:48:51 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

Clarify SimpleXML comparison logic

Browse source
This commit is contained in:
Nikita Popov 2020-03-31 12:48:57 +02:00
parent fb5bfcb75b
commit 6bf483a94a
1 changed files with 15 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

22
ext/simplexml/simplexml.c
View file

@ -1291,16 +1291,24 @@ static int sxe_objects_compare(zval *object1, zval *object2) /* {{{ */
sxe1 = Z_SXEOBJ_P(object1); sxe1 = Z_SXEOBJ_P(object1);
sxe2 = Z_SXEOBJ_P(object2); sxe2 = Z_SXEOBJ_P(object2);
if (sxe1->node == NULL) { if (sxe1->node != NULL && sxe2->node != NULL) {
if (sxe2->node) { /* Both nodes set: Only support equality comparison between nodes. */
return 1; if (sxe1->node == sxe2->node) {
} else if (sxe1->document->ptr == sxe2->document->ptr) {
return 0; return 0;
} }
return 1; return ZEND_UNCOMPARABLE;
} else {
return !(sxe1->node == sxe2->node);
} }
if (sxe1->node == NULL && sxe2->node == NULL) {
/* Both nodes not set: Only support equality comparison between documents. */
if (sxe1->document->ptr == sxe2->document->ptr) {
return 0;
}
return ZEND_UNCOMPARABLE;
}
/* Only one of the nodes set: Cannot compare. */
return ZEND_UNCOMPARABLE;
} }
/* }}} */ /* }}} */