archive/php-src
1
0
Fork 0
mirror of https://github.com/php/php-src.git synced 2025-08-20 01:14:28 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

Use snprintf and strncat to make the static analyzers happy

Browse source
This commit is contained in:
Pierrick Charron 2011-08-08 03:08:59 +00:00
parent 8bae5e220e
commit 6ea19be489
1 changed files with 3 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

6
Zend/zend.c
View file

@ -870,7 +870,7 @@ void zend_append_version_info(const zend_extension *extension) /* {{{ */
char *new_info; char *new_info;
uint new_info_length; uint new_info_length;
new_info_length = sizeof(" with v, by \n") new_info_length = sizeof(" with v, , by \n")
+ strlen(extension->name) + strlen(extension->name)
+ strlen(extension->version) + strlen(extension->version)
+ strlen(extension->copyright) + strlen(extension->copyright)
@ -878,10 +878,10 @@ void zend_append_version_info(const zend_extension *extension) /* {{{ */
new_info = (char *) malloc(new_info_length + 1); new_info = (char *) malloc(new_info_length + 1);
sprintf(new_info, " with %s v%s, %s, by %s\n", extension->name, extension->version, extension->copyright, extension->author); snprintf(new_info, new_info_length, " with %s v%s, %s, by %s\n", extension->name, extension->version, extension->copyright, extension->author);
zend_version_info = (char *) realloc(zend_version_info, zend_version_info_length+new_info_length + 1); zend_version_info = (char *) realloc(zend_version_info, zend_version_info_length+new_info_length + 1);
strcat(zend_version_info, new_info); strncat(zend_version_info, new_info, new_info_length);
zend_version_info_length += new_info_length; zend_version_info_length += new_info_length;
free(new_info); free(new_info);
} }