archive/php-src
1
0
Fork 0
mirror of https://github.com/php/php-src.git synced 2025-08-16 05:58:45 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

Fix #77932: File extensions are case-sensitive

Browse source 
The file extension to mime type mapping *must* not depend on the file
extension's case for case-insensitive file systems, and *should* not
for case-sensitive file systems.
This commit is contained in:
Christoph M. Becker 2020-07-27 10:13:52 +02:00
parent 874284d1c9
commit 6f18d7e2f9
2 changed files with 12 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

1
NEWS
View file

@ -4,6 +4,7 @@ PHP NEWS
- Core: - Core:
. Fixed bug #79884 (PHP_CONFIG_FILE_PATH is meaningless). (cmb) . Fixed bug #79884 (PHP_CONFIG_FILE_PATH is meaningless). (cmb)
. Fixed bug #77932 (File extensions are case-sensitive). (cmb)
?? ??? ????, PHP 7.3.21 ?? ??? ????, PHP 7.3.21

13
sapi/cli/php_cli_server.c
View file

@ -365,7 +365,13 @@ static void append_essential_headers(smart_str* buffer, php_cli_server_client *c
static const char *get_mime_type(const php_cli_server *server, const char *ext, size_t ext_len) /* {{{ */ static const char *get_mime_type(const php_cli_server *server, const char *ext, size_t ext_len) /* {{{ */
{ {
return (const char*)zend_hash_str_find_ptr(&server->extension_mime_types, ext, ext_len); char *ret;
ALLOCA_FLAG(use_heap)
char *ext_lower = do_alloca(ext_len + 1, use_heap);
zend_str_tolower_copy(ext_lower, ext, ext_len);
ret = zend_hash_str_find_ptr(&server->extension_mime_types, ext_lower, ext_len);
free_alloca(ext_lower, use_heap);
return (const char*)ret;
} /* }}} */ } /* }}} */
PHP_FUNCTION(apache_request_headers) /* {{{ */ PHP_FUNCTION(apache_request_headers) /* {{{ */
@ -2140,9 +2146,12 @@ static int php_cli_server_dispatch_router(php_cli_server *server, php_cli_server
static int php_cli_server_dispatch(php_cli_server *server, php_cli_server_client *client) /* {{{ */ static int php_cli_server_dispatch(php_cli_server *server, php_cli_server_client *client) /* {{{ */
{ {
int is_static_file = 0; int is_static_file = 0;
const char *ext = client->request.ext;
SG(server_context) = client; SG(server_context) = client;
if (client->request.ext_len != 3 || memcmp(client->request.ext, "php", 3) || !client->request.path_translated) { if (client->request.ext_len != 3
|| (ext[0] != 'p' && ext[0] != 'P') || (ext[1] != 'h' && ext[1] != 'H') || (ext[2] != 'p' && ext[2] != 'P')
|| !client->request.path_translated) {
is_static_file = 1; is_static_file = 1;
} }