From 6fb1c7a7427582641ab25c128b871fbcaa28dfe0 Mon Sep 17 00:00:00 2001 From: Kamil Tekiela Date: Fri, 8 Mar 2024 16:59:51 +0100 Subject: [PATCH] Remove unnecessary skip checks (#13637) --- ext/mysqli/tests/bug46614.phpt | 3 - ext/mysqli/tests/bug47050.phpt | 3 - ext/mysqli/tests/bug73800.phpt | 1 - ext/mysqli/tests/bug77597.phpt | 1 - ext/mysqli/tests/bug79375.phpt | 1 - ext/mysqli/tests/bug80837.phpt | 1 - ext/mysqli/tests/deprecated_constants.phpt | 9 +- ext/mysqli/tests/mysqli_explain_metadata.phpt | 3 +- ext/mysqli/tests/mysqli_get_client_stats.phpt | 3 - ...mysqli_get_client_stats_implicit_free.phpt | 3 - .../tests/mysqli_get_client_stats_off.phpt | 3 - .../tests/mysqli_get_client_stats_ps.phpt | 3 - .../mysqli_get_client_stats_skipped.phpt | 3 - .../tests/mysqli_get_connection_stats.phpt | 3 - .../mysqli_get_connection_stats_off.phpt | 3 - .../mysqli_stmt_execute_stored_proc.phpt | 52 +++---- ext/mysqli/tests/mysqli_stmt_get_result.phpt | 3 - ext/mysqli/tests/mysqli_stmt_get_result2.phpt | 2 - .../tests/mysqli_stmt_get_result_bit.phpt | 4 - .../mysqli_stmt_get_result_field_count.phpt | 3 - .../tests/mysqli_stmt_get_result_geom.phpt | 3 - .../mysqli_stmt_get_result_metadata.phpt | 3 - ..._stmt_get_result_metadata_fetch_field.phpt | 3 - .../mysqli_stmt_get_result_non_select.phpt | 3 - .../tests/mysqli_stmt_get_result_seek.phpt | 3 - .../tests/mysqli_stmt_get_result_types.phpt | 3 - .../mysqli_stmt_result_metadata_sqltests.phpt | 144 +++++++++--------- .../tests/mysqli_store_result_buffered_c.phpt | 3 - 28 files changed, 97 insertions(+), 175 deletions(-) diff --git a/ext/mysqli/tests/bug46614.phpt b/ext/mysqli/tests/bug46614.phpt index 89392d969d5..00e4b508c21 100644 --- a/ext/mysqli/tests/bug46614.phpt +++ b/ext/mysqli/tests/bug46614.phpt @@ -5,9 +5,6 @@ mysqli --SKIPIF-- --FILE-- --FILE-- --FILE-- --FILE-- --FILE-- --FILE-- diff --git a/ext/mysqli/tests/mysqli_explain_metadata.phpt b/ext/mysqli/tests/mysqli_explain_metadata.phpt index 320f2c71245..a5ddf5462a5 100644 --- a/ext/mysqli/tests/mysqli_explain_metadata.phpt +++ b/ext/mysqli/tests/mysqli_explain_metadata.phpt @@ -95,8 +95,7 @@ require_once 'skipifconnectfailure.inc'; var_dump($fields); } - if (function_exists('mysqli_stmt_get_result') && - $stmt->prepare('EXPLAIN SELECT t1.*, t2.* FROM test AS t1, test AS t2') && + if ($stmt->prepare('EXPLAIN SELECT t1.*, t2.* FROM test AS t1, test AS t2') && $stmt->execute()) { if (!$res_stmt = mysqli_stmt_get_result($stmt)) { printf("[017] Cannot fetch result from PS [%d] %s\n", diff --git a/ext/mysqli/tests/mysqli_get_client_stats.phpt b/ext/mysqli/tests/mysqli_get_client_stats.phpt index 141a3901271..a8d509eb627 100644 --- a/ext/mysqli/tests/mysqli_get_client_stats.phpt +++ b/ext/mysqli/tests/mysqli_get_client_stats.phpt @@ -5,9 +5,6 @@ mysqli --SKIPIF-- --INI-- mysqlnd.collect_statistics=1 diff --git a/ext/mysqli/tests/mysqli_get_client_stats_implicit_free.phpt b/ext/mysqli/tests/mysqli_get_client_stats_implicit_free.phpt index d4cdfabc28d..35ab6c617e9 100644 --- a/ext/mysqli/tests/mysqli_get_client_stats_implicit_free.phpt +++ b/ext/mysqli/tests/mysqli_get_client_stats_implicit_free.phpt @@ -5,9 +5,6 @@ mysqli --SKIPIF-- --INI-- mysqlnd.collect_statistics=1 diff --git a/ext/mysqli/tests/mysqli_get_client_stats_off.phpt b/ext/mysqli/tests/mysqli_get_client_stats_off.phpt index 67459a8799c..ebb199d90f2 100644 --- a/ext/mysqli/tests/mysqli_get_client_stats_off.phpt +++ b/ext/mysqli/tests/mysqli_get_client_stats_off.phpt @@ -5,9 +5,6 @@ mysqli --SKIPIF-- --INI-- mysqlnd.collect_statistics=0 diff --git a/ext/mysqli/tests/mysqli_get_client_stats_ps.phpt b/ext/mysqli/tests/mysqli_get_client_stats_ps.phpt index bfa8cc370c2..c0f6ddb3c35 100644 --- a/ext/mysqli/tests/mysqli_get_client_stats_ps.phpt +++ b/ext/mysqli/tests/mysqli_get_client_stats_ps.phpt @@ -5,9 +5,6 @@ mysqli --SKIPIF-- --INI-- mysqlnd.collect_statistics=1 diff --git a/ext/mysqli/tests/mysqli_get_client_stats_skipped.phpt b/ext/mysqli/tests/mysqli_get_client_stats_skipped.phpt index babf964fdaa..aaf40988591 100644 --- a/ext/mysqli/tests/mysqli_get_client_stats_skipped.phpt +++ b/ext/mysqli/tests/mysqli_get_client_stats_skipped.phpt @@ -8,9 +8,6 @@ mysqli --SKIPIF-- --FILE-- --FILE-- --FILE-- --FILE-- --FILE-- --FILE-- diff --git a/ext/mysqli/tests/mysqli_stmt_get_result_metadata.phpt b/ext/mysqli/tests/mysqli_stmt_get_result_metadata.phpt index 37afd39d15e..5a2ac21ff97 100644 --- a/ext/mysqli/tests/mysqli_stmt_get_result_metadata.phpt +++ b/ext/mysqli/tests/mysqli_stmt_get_result_metadata.phpt @@ -5,9 +5,6 @@ mysqli --SKIPIF-- --FILE-- --FILE-- --FILE-- --FILE-- --FILE-- mysqli_num_fields($res), - 'fetch_field' => mysqli_fetch_field($res), - 'fetch_field_direct0' => mysqli_fetch_field_direct($res, 0), - 'fetch_field_direct1' => @mysqli_fetch_field_direct($res, 1), - 'fetch_fields' => count(mysqli_fetch_fields($res)), - 'field_count' => mysqli_field_count($link), - 'field_seek-1' => @mysqli_field_seek($res, -1), - 'field_seek0' => mysqli_field_seek($res, 0), - 'field_tell' => mysqli_field_tell($res), - ); - if (is_object($meta_res['fetch_field'])) { - $meta_res['fetch_field']->charsetnr = 'ignore'; - $meta_res['fetch_field']->flags = 'ignore'; - } - if (is_object($meta_res['fetch_field_direct0'])) { - $meta_res['fetch_field_direct0']->charsetnr = 'ignore'; - $meta_res['fetch_field_direct0']->flags = 'ignore'; - } - if (is_object($meta_res['fetch_field_direct1'])) { - $meta_res['fetch_field_direct1']->charsetnr = 'ignore'; - $meta_res['fetch_field_direct1']->flags = 'ignore'; - } - mysqli_free_result($res); - if ($check_mysqlnd && $meta_res != $expected_mysqlnd) { - printf("[%04d - %s] Metadata differs from expected\n", - $offset + 11, $sql); + $meta_res = array( + 'num_fields' => mysqli_num_fields($res), + 'fetch_field' => mysqli_fetch_field($res), + 'fetch_field_direct0' => mysqli_fetch_field_direct($res, 0), + 'fetch_field_direct1' => @mysqli_fetch_field_direct($res, 1), + 'fetch_fields' => count(mysqli_fetch_fields($res)), + 'field_count' => mysqli_field_count($link), + 'field_seek-1' => @mysqli_field_seek($res, -1), + 'field_seek0' => mysqli_field_seek($res, 0), + 'field_tell' => mysqli_field_tell($res), + ); + if (is_object($meta_res['fetch_field'])) { + $meta_res['fetch_field']->charsetnr = 'ignore'; + $meta_res['fetch_field']->flags = 'ignore'; + } + if (is_object($meta_res['fetch_field_direct0'])) { + $meta_res['fetch_field_direct0']->charsetnr = 'ignore'; + $meta_res['fetch_field_direct0']->flags = 'ignore'; + } + if (is_object($meta_res['fetch_field_direct1'])) { + $meta_res['fetch_field_direct1']->charsetnr = 'ignore'; + $meta_res['fetch_field_direct1']->flags = 'ignore'; + } + mysqli_free_result($res); + if ($check_mysqlnd && $meta_res != $expected_mysqlnd) { + printf("[%04d - %s] Metadata differs from expected\n", + $offset + 11, $sql); + var_dump($meta_res); + var_dump($expected_mysqlnd); + } else { + if ($meta_res['field_count'] < 1) { + printf("[%04d - %s] Metadata seems wrong, no fields?\n", + $offset + 12, $sql); var_dump($meta_res); - var_dump($expected_mysqlnd); - } else { - if ($meta_res['field_count'] < 1) { - printf("[%04d - %s] Metadata seems wrong, no fields?\n", - $offset + 12, $sql); - var_dump($meta_res); - var_dump(mysqli_fetch_assoc($res)); - } - } - - if ($compare && $meta_res != $meta) { - printf("[%04d - %s] Metadata returned by mysqli_stmt_result_metadata() and mysqli_stmt_get_result() differ\n", - $offset + 13, $sql); - var_dump($meta_res); - var_dump($meta); + var_dump(mysqli_fetch_assoc($res)); } + } + if ($compare && $meta_res != $meta) { + printf("[%04d - %s] Metadata returned by mysqli_stmt_result_metadata() and mysqli_stmt_get_result() differ\n", + $offset + 13, $sql); + var_dump($meta_res); + var_dump($meta); } mysqli_stmt_close($stmt); diff --git a/ext/mysqli/tests/mysqli_store_result_buffered_c.phpt b/ext/mysqli/tests/mysqli_store_result_buffered_c.phpt index a1ee3182370..f68d01a62db 100644 --- a/ext/mysqli/tests/mysqli_store_result_buffered_c.phpt +++ b/ext/mysqli/tests/mysqli_store_result_buffered_c.phpt @@ -5,9 +5,6 @@ mysqli --SKIPIF-- --FILE--