From 79aa615b55bf95a293cbfc9b33e9ec3e3314fb8d Mon Sep 17 00:00:00 2001 From: Pierre Joye Date: Wed, 27 Jan 2010 14:41:06 +0000 Subject: [PATCH] - fix leak when the SID is already used and duplicated --- TSRM/tsrm_win32.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/TSRM/tsrm_win32.c b/TSRM/tsrm_win32.c index 7b2deceb54d..67742f0b389 100644 --- a/TSRM/tsrm_win32.c +++ b/TSRM/tsrm_win32.c @@ -170,6 +170,7 @@ PSID tsrm_win32_get_token_sid(HANDLE hToken) /* ConvertSidToStringSid(pTokenUser->User.Sid, &ptcSidOwner); */ pResultSid = malloc(sid_len); + if (!pResultSid) { goto Finished; } @@ -271,6 +272,9 @@ TSRM_API int tsrm_win32_access(const char *pathname, int mode) if (!DuplicateToken(thread_token, SecurityImpersonation, &TWG(impersonation_token))) { goto Finished; } + } else { + /* we already have it, free it then */ + free(token_sid); } if (CWDG(realpath_cache_size_limit)) {