archive/php-src
1
0
Fork 0
mirror of https://github.com/php/php-src.git synced 2025-08-15 21:48:51 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

random: Add clarifying comments to the implementation of CombinedLCG

Browse source 
The implementation is needlessly obfuscated. It's not immediately clear that
MODMULT is a simple modular multiplication, despite its name. Specifically it's
not clear which of the parameters is the second factor.

Furthermore the stated period is off-by-one: A value of `0` is part of its own
chain, thus it may not be included in the period of the underlying generators.
This commit is contained in:
Tim Düsterhus 2024-04-06 17:46:28 +02:00
parent cf313321c2
commit 7c851042cb
No known key found for this signature in database
GPG key ID: 8FF75566094168AF
1 changed files with 7 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

9
ext/random/engine_combinedlcg.c
View file

@ -27,8 +27,11 @@
/* /*
* combinedLCG() returns a pseudo random number in the range of (0, 1). * combinedLCG() returns a pseudo random number in the range of (0, 1).
* The function combines two CGs with periods of * The function combines two CGs with periods of
* 2^31 - 85 and 2^31 - 249. The period of this function * 2^31 - 85 - 1 and 2^31 - 249 - 1. The period of this function
* is equal to the product of both primes. * is equal to the product of the two underlying periods, divided
* by factors shared by the underlying periods, i.e. 2.3 * 10^18.
*
* see: https://library.sciencemadness.org/lanl1_a/lib-www/numerica/f7-1.pdf
*/ */
#define MODMULT(a, b, c, m, s) q = s / a; s = b * (s - a * q) - c * q; if (s < 0) s += m #define MODMULT(a, b, c, m, s) q = s / a; s = b * (s - a * q) - c * q; if (s < 0) s += m
@ -43,7 +46,9 @@ static php_random_result generate(void *state)
php_random_status_state_combinedlcg *s = state; php_random_status_state_combinedlcg *s = state;
int32_t q, z; int32_t q, z;
/* s->state[0] = (s->state[0] * 40014) % 2147483563; */
MODMULT(53668, 40014, 12211, 2147483563L, s->state[0]); MODMULT(53668, 40014, 12211, 2147483563L, s->state[0]);
/* s->state[1] = (s->state[1] * 40692) % 2147483399; */
MODMULT(52774, 40692, 3791, 2147483399L, s->state[1]); MODMULT(52774, 40692, 3791, 2147483399L, s->state[1]);
z = s->state[0] - s->state[1]; z = s->state[0] - s->state[1];