archive/php-src
1
0
Fork 0
mirror of https://github.com/php/php-src.git synced 2025-08-15 21:48:51 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

gen_stub: stop cloning Type objects

Browse source 
They are immutable
This commit is contained in:
Daniel Scherzer 2025-02-21 17:36:39 -08:00 • committed by Máté Kocsis
parent cecbcd9f3f
commit 8485a804ab
1 changed files with 2 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

9
build/gen_stub.php
View file

@ -531,6 +531,8 @@ class SimpleType {
} }
} }
// Instances of Type are immutable and do not need to be cloned
// when held by an object that is cloned
class Type { class Type {
/** @var SimpleType[] */ /** @var SimpleType[] */
public /* readonly */ array $types; public /* readonly */ array $types;
@ -3146,13 +3148,6 @@ class PropertyInfo extends VariableLike
$fieldsynopsisElement->appendChild($doc->createElement("modifier", "readonly")); $fieldsynopsisElement->appendChild($doc->createElement("modifier", "readonly"));
} }
} }
public function __clone()
{
if ($this->type) {
$this->type = clone $this->type;
}
}
} }
class EnumCaseInfo { class EnumCaseInfo {