From a015fa83a735da7342dd7ae172c4516265bed41d Mon Sep 17 00:00:00 2001 From: Arpad Ray Date: Fri, 19 Jul 2013 19:19:48 +0100 Subject: [PATCH] Fixed bug #65291 - get_defined_constants() crash with __CLASS__ in trait --- NEWS | 2 ++ Zend/tests/bug65291.phpt | 24 ++++++++++++++++++++++++ Zend/zend_builtin_functions.c | 5 +++++ 3 files changed, 31 insertions(+) create mode 100644 Zend/tests/bug65291.phpt diff --git a/NEWS b/NEWS index 4826d0ca98a..011b3d890b7 100644 --- a/NEWS +++ b/NEWS @@ -4,6 +4,8 @@ PHP NEWS - Core. . Improve fix for bug #63186 (compile failure on netbsd). (Matteo) + . Fixed bug #65291 (get_defined_constants() causes PHP to crash in a very + limited case). (Arpad) - Session: . Fixed bug #62129 (rfc1867 crashes php even though turned off). (gxd305 at diff --git a/Zend/tests/bug65291.phpt b/Zend/tests/bug65291.phpt new file mode 100644 index 00000000000..9e5cca5c357 --- /dev/null +++ b/Zend/tests/bug65291.phpt @@ -0,0 +1,24 @@ +--TEST-- +Bug #65291 - get_defined_constants() causes PHP to crash in a very limited case. +--FILE-- + +--EXPECT-- +Tester diff --git a/Zend/zend_builtin_functions.c b/Zend/zend_builtin_functions.c index f29676bac0c..1aba64e1028 100644 --- a/Zend/zend_builtin_functions.c +++ b/Zend/zend_builtin_functions.c @@ -1926,6 +1926,11 @@ static int add_constant_info(zend_constant *constant, void *arg TSRMLS_DC) zval *name_array = (zval *)arg; zval *const_val; + if (!constant->name) { + /* skip special constants */ + return 0; + } + MAKE_STD_ZVAL(const_val); *const_val = constant->value; zval_copy_ctor(const_val);