Voidify zend_cfg_identify_loops()

It always returned SUCCESS
This commit is contained in:
George Peter Banyard 2021-09-20 17:44:15 +01:00
parent 53c72bd6e0
commit a06d6c36d4
4 changed files with 4 additions and 10 deletions

View file

@ -67,9 +67,7 @@ zend_result zend_dfa_analyze_op_array(zend_op_array *op_array, zend_optimizer_ct
zend_cfg_compute_dominators_tree(op_array, &ssa->cfg);
/* Identify reducible and irreducible loops */
if (zend_cfg_identify_loops(op_array, &ssa->cfg) != SUCCESS) {
return FAILURE;
}
zend_cfg_identify_loops(op_array, &ssa->cfg);
if (ctx->debug_level & ZEND_DUMP_DFA_DOMINATORS) {
zend_dump_dominators(op_array, &ssa->cfg);

View file

@ -793,7 +793,7 @@ static void swap_blocks(block_info *a, block_info *b) {
*b = tmp;
}
ZEND_API int zend_cfg_identify_loops(const zend_op_array *op_array, zend_cfg *cfg) /* {{{ */
ZEND_API void zend_cfg_identify_loops(const zend_op_array *op_array, zend_cfg *cfg) /* {{{ */
{
int i, j, k, n;
int time;
@ -905,7 +905,5 @@ ZEND_API int zend_cfg_identify_loops(const zend_op_array *op_array, zend_cfg *cf
ZEND_WORKLIST_FREE_ALLOCA(&work, list_use_heap);
cfg->flags |= flag;
return SUCCESS;
}
/* }}} */

View file

@ -120,7 +120,7 @@ ZEND_API void zend_build_cfg(zend_arena **arena, const zend_op_array *op_array,
void zend_cfg_remark_reachable_blocks(const zend_op_array *op_array, zend_cfg *cfg);
ZEND_API void zend_cfg_build_predecessors(zend_arena **arena, zend_cfg *cfg);
ZEND_API void zend_cfg_compute_dominators_tree(const zend_op_array *op_array, zend_cfg *cfg);
ZEND_API int zend_cfg_identify_loops(const zend_op_array *op_array, zend_cfg *cfg);
ZEND_API void zend_cfg_identify_loops(const zend_op_array *op_array, zend_cfg *cfg);
END_EXTERN_C()

View file

@ -1283,9 +1283,7 @@ static int zend_jit_build_cfg(const zend_op_array *op_array, zend_cfg *cfg)
zend_cfg_compute_dominators_tree(op_array, cfg);
/* Identify reducible and irreducible loops */
if (zend_cfg_identify_loops(op_array, cfg) != SUCCESS) {
return FAILURE;
}
zend_cfg_identify_loops(op_array, cfg);
return SUCCESS;
}