archive/php-src
1
0
Fork 0
mirror of https://github.com/php/php-src.git synced 2025-08-16 05:58:45 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

Check missing parameter types in stubs

Browse source 
[skip ci] Closes GH-5627
This commit is contained in:
Máté Kocsis 2020-07-30 14:31:47 +02:00
parent cb2f689778
commit a10f8876ef
No known key found for this signature in database
GPG key ID: FD055E41728BF310
1 changed files with 23 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

27
build/gen_stub.php
View file

@ -576,11 +576,23 @@ class DocCommentTag {
public function getVariableName(): string {
$value = $this->getValue();
if ($value === null || strlen($value) === 0 || $value[0] !== '$') {
throw new Exception("@$this->name not followed by variable name");
if ($value === null || strlen($value) === 0) {
throw new Exception("@$this->name doesn't have any value");
}
return substr($value, 1);
$matches = [];
if ($this->name === "param") {
preg_match('/^\s*[\w\|\\\\]+\s*\$(\w+).*$/', $value, $matches);
} elseif ($this->name === "prefer-ref") {
preg_match('/^\s*\$(\w+).*$/', $value, $matches);
}
if (isset($matches[1]) === false) {
throw new Exception("@$this->name doesn't contain variable name or has an invalid format \"$value\"");
}
return $matches[1];
}
}
@ -610,6 +622,7 @@ function parseFunctionLike(
$alias = null;
$isDeprecated = false;
$haveDocReturnType = false;
$docParamTypes = [];
if ($comment) {
$tags = parseDocComment($comment);
@ -631,6 +644,8 @@ function parseFunctionLike(
$isDeprecated = true;
} else if ($tag->name === 'return') {
$haveDocReturnType = true;
} else if ($tag->name === 'param') {
$docParamTypes[$tag->getVariableName()] = true;
}
}
}
@ -656,6 +671,10 @@ function parseFunctionLike(
}
$type = $param->type ? Type::fromNode($param->type) : null;
if ($type === null && !isset($docParamTypes[$varName])) {
throw new Exception("Missing parameter type for function $name()");
}
if ($param->default instanceof Expr\ConstFetch &&
$param->default->name->toLowerString() === "null" &&
$type && !$type->isNullable()
@ -1103,7 +1122,7 @@ function initPhpParser() {
$optind = null;
$options = getopt("f", ["force-regeneration"], $optind);
$forceRegeneration = isset($options["f"]) || isset($options["force-regeneration"]);
$location = $argv[$optind + 1] ?? ".";
$location = $argv[$optind] ?? ".";
if (is_file($location)) {
// Generate single file.