archive/php-src
1
0
Fork 0
mirror of https://github.com/php/php-src.git synced 2025-08-15 21:48:51 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

Use-after-free in extract() with EXTR_REFS

Browse source 
Fixes GH-18209
Closes GH-18211
This commit is contained in:
Ilija Tovilo 2025-03-31 22:06:17 +02:00
parent 13d51f895b
commit a21065e6eb
No known key found for this signature in database
GPG key ID: 5050C66BFCD1015A
3 changed files with 27 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

1
NEWS
View file

@ -9,6 +9,7 @@ PHP NEWS
- Standard: - Standard:
. Fixed bug GH-18145 (php8ts crashes in php_clear_stat_cache()). . Fixed bug GH-18145 (php8ts crashes in php_clear_stat_cache()).
(Jakub Zelenka) (Jakub Zelenka)
. Fixed bug GH-18209 (Use-after-free in extract() with EXTR_REFS). (ilutov)
10 Apr 2025, PHP 8.3.20 10 Apr 2025, PHP 8.3.20

4
ext/standard/array.c
View file

@ -1863,8 +1863,10 @@ static zend_long php_extract_ref_overwrite(zend_array *arr, zend_array *symbol_t
} else { } else {
ZVAL_MAKE_REF_EX(entry, 2); ZVAL_MAKE_REF_EX(entry, 2);
} }
zval_ptr_dtor(orig_var); zval garbage;
ZVAL_COPY_VALUE(&garbage, orig_var);
ZVAL_REF(orig_var, Z_REF_P(entry)); ZVAL_REF(orig_var, Z_REF_P(entry));
zval_ptr_dtor(&garbage);
} else { } else {
if (Z_ISREF_P(entry)) { if (Z_ISREF_P(entry)) {
Z_ADDREF_P(entry); Z_ADDREF_P(entry);

23
ext/standard/tests/gh18209.phpt Normal file
View file

@ -0,0 +1,23 @@
--TEST--
GH-18209: Use-after-free in extract() with EXTR_REFS
--CREDITS--
Noam Rathaus (nrathaus)
--FILE--
<?php
class C {
public function __destruct() {
var_dump($GLOBALS['b']);
$GLOBALS['b'] = 43;
}
}
$b = new C;
$array = ['b' => 42];
extract($array, EXTR_REFS);
var_dump($b);
?>
--EXPECT--
int(42)
int(43)