archive/php-src
1
0
Fork 0
mirror of https://github.com/php/php-src.git synced 2025-08-16 05:58:45 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

Fix leak in gmp_export()

Browse source
This commit is contained in:
Nikita Popov 2020-10-15 10:16:22 +02:00
parent db8bf0a9e0
commit a29016d70d
2 changed files with 6 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

4
ext/gmp/gmp.c
View file

@ -1155,7 +1155,7 @@ ZEND_FUNCTION(gmp_export)
FETCH_GMP_ZVAL(gmpnumber, gmpnumber_arg, temp_a);
if (mpz_sgn(gmpnumber) == 0) {
RETURN_EMPTY_STRING();
RETVAL_EMPTY_STRING();
} else {
size_t bits_per_word = size * 8;
size_t count = (mpz_sizeinbase(gmpnumber, 2) + bits_per_word - 1) / bits_per_word;
@ -1164,7 +1164,7 @@ ZEND_FUNCTION(gmp_export)
mpz_export(ZSTR_VAL(out_string), NULL, order, size, endian, 0, gmpnumber);
ZSTR_VAL(out_string)[ZSTR_LEN(out_string)] = '\0';
RETURN_NEW_STR(out_string);
RETVAL_NEW_STR(out_string);
}
FREE_GMP_TEMP(temp_a);

4
ext/gmp/tests/gmp_export.phpt
View file

@ -50,6 +50,9 @@ foreach ($export as $k => $test) {
var_dump($passed);
// Argument converted from int to GMP
var_dump(bin2hex(gmp_export(0xff)));
// Invalid arguments (zpp failure)
var_dump(gmp_export());
@ -62,6 +65,7 @@ var_dump(gmp_export(123, 1, GMP_MSW_FIRST | GMP_LSW_FIRST));
var_dump(gmp_export(123, 1, GMP_BIG_ENDIAN | GMP_LITTLE_ENDIAN));
--EXPECTF--
bool(true)
string(2) "ff"
Warning: gmp_export() expects at least 1 parameter, 0 given in %s on line %d
NULL