Don't export php_pdo_int.h

This is, as the name and a comment in the header imply, an internal
header which is not supposed to be used by extensions other than PDO
(not even by drivers).

Since there is apparently no need to include this header in the parsers
of the drivers, we remove these includes, and no longer declare the
header to be installed.  Given that the header is only exported for a
couple of weeks[1], this is not considered to be a BC break, because
it's unlikely that external drivers have already been adjusted to use
this header, and otherwise they can still be fixed; PHP 8.4 is still in
the pre-release stage.

[1] <https://github.com/php/php-src/pull/14797>

Closes GH-15688.
This commit is contained in:
Christoph M. Becker 2024-09-01 12:17:04 +02:00
parent 1a126c540a
commit a57ce052cd
No known key found for this signature in database
GPG key ID: D66C9593118BCCB6
7 changed files with 4 additions and 6 deletions

4
NEWS
View file

@ -20,6 +20,10 @@ PHP NEWS
- GD:
. Added gdImageClone to bundled libgd. (David Carlier)
- PDO:
. The internal header php_pdo_int.h is no longer installed; it is not
supposed to be used by PDO drivers. (cmb)
- PDO_Firebird:
. Fixed GH-15604 (Always make input parameters nullable). (sim1984)

View file

@ -16,7 +16,6 @@ if test "$PHP_PDO" != "no"; then
pdo_sql_parser.h
php_pdo_driver.h
php_pdo_error.h
php_pdo_int.h
php_pdo.h
]))
PHP_ADD_MAKEFILE_FRAGMENT

View file

@ -10,7 +10,6 @@ if (PHP_PDO != "no") {
"pdo_sql_parser.h " +
"php_pdo_driver.h " +
"php_pdo_error.h " +
"php_pdo_int.h " +
"php_pdo.h"
);
}

View file

@ -16,7 +16,6 @@
#include "php.h"
#include "php_pdo_driver.h"
#include "php_pdo_int.h"
#include "pdo_sql_parser.h"
static int default_scanner(pdo_scanner_t *s)

View file

@ -17,7 +17,6 @@
#include "php.h"
#include "ext/pdo/php_pdo_driver.h"
#include "ext/pdo/php_pdo_int.h"
#include "ext/pdo/pdo_sql_parser.h"
int pdo_mysql_scanner(pdo_scanner_t *s)

View file

@ -17,7 +17,6 @@
#include "php.h"
#include "ext/pdo/php_pdo_driver.h"
#include "ext/pdo/php_pdo_int.h"
#include "ext/pdo/pdo_sql_parser.h"
int pdo_pgsql_scanner(pdo_scanner_t *s)

View file

@ -17,7 +17,6 @@
#include "php.h"
#include "ext/pdo/php_pdo_driver.h"
#include "ext/pdo/php_pdo_int.h"
#include "ext/pdo/pdo_sql_parser.h"
int pdo_sqlite_scanner(pdo_scanner_t *s)