From a87f4dd93005f595d23b87f570775f8fc3887c68 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Michal=20Pr=C3=ADvozn=C3=ADk?= Date: Thu, 16 Jun 2022 15:34:37 +0200 Subject: [PATCH] check_parameters.php: Make the script's retval reflect errors When the check_parameters.php script meets an error it prints it out but the exit value is not affected, it's still 0. This does not fly with projects that want to run this script as a part of their test suite. Therefore, make the script return 0 on success and 2 if any error was reported. Signed-off-by: Michal Privoznik Closes GH-8790. --- scripts/dev/check_parameters.php | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/scripts/dev/check_parameters.php b/scripts/dev/check_parameters.php index f8e905cc021..a68f5ebe5fd 100755 --- a/scripts/dev/check_parameters.php +++ b/scripts/dev/check_parameters.php @@ -51,7 +51,7 @@ $API_params = array( /** reports an error, according to its level */ function error($str, $level = 0) { - global $current_file, $current_function, $line; + global $current_file, $current_function, $line, $error_reported; if ($level <= REPORT_LEVEL) { if (strpos($current_file,PHPDIR) === 0) { @@ -60,6 +60,7 @@ function error($str, $level = 0) $filename = $current_file; } echo $filename , " [$line] $current_function : $str\n"; + $error_reported = true; } } @@ -372,6 +373,9 @@ foreach($dirs as $dir) { } } +$error_reported = false; foreach ($dirs as $dir) { recurse(realpath($dir)); } + +exit($error_reported === false ? 0 : 2);