archive/php-src
1
0
Fork 0
mirror of https://github.com/php/php-src.git synced 2025-08-15 21:48:51 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

Make arginfo printing of prefer-ref arguments nicer

Browse source
This commit is contained in:
Nikita Popov 2019-08-26 15:39:39 +02:00
parent e047e9d893
commit a98307df87
3 changed files with 31 additions and 19 deletions
Download patch file Download diff file Expand all files Collapse all files

22
scripts/dev/gen_stub.php
View file

@ -135,6 +135,18 @@ class ArgInfo {
&& $this->isVariadic === $other->isVariadic
&& Type::equals($this->type, $other->type);
}
public function getSendByString(): string {
switch ($this->sendBy) {
case self::SEND_BY_VAL:
return "0";
case self::SEND_BY_REF:
return "1";
case self::SEND_PREFER_REF:
return "ZEND_SEND_PREFER_REF";
}
throw new Exception("Invalid sendBy value");
}
}
class ReturnInfo {
@ -373,20 +385,20 @@ function funcInfoToCode(FuncInfo $funcInfo): string {
if ($argInfo->type) {
if ($argInfo->type->isBuiltin) {
$code .= sprintf(
"\tZEND_%s_TYPE_INFO(%d, %s, %s, %d)\n",
$argKind, $argInfo->sendBy, $argInfo->name,
"\tZEND_%s_TYPE_INFO(%s, %s, %s, %d)\n",
$argKind, $argInfo->getSendByString(), $argInfo->name,
$argInfo->type->toTypeCode(), $argInfo->type->isNullable
);
} else {
$code .= sprintf(
"\tZEND_%s_OBJ_INFO(%d, %s, %s, %d)\n",
$argKind, $argInfo->sendBy, $argInfo->name,
"\tZEND_%s_OBJ_INFO(%s, %s, %s, %d)\n",
$argKind, $argInfo->getSendByString(), $argInfo->name,
str_replace('\\', '\\\\', $argInfo->type->name), $argInfo->type->isNullable
);
}
} else {
$code .= sprintf(
"\tZEND_%s_INFO(%d, %s)\n", $argKind, $argInfo->sendBy, $argInfo->name);
"\tZEND_%s_INFO(%s, %s)\n", $argKind, $argInfo->getSendByString(), $argInfo->name);
}
}