archive/php-src
1
0
Fork 0
mirror of https://github.com/php/php-src.git synced 2025-08-15 21:48:51 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

Use specialized functions/macros to reduce code size in ext/random (#18499)

Browse source 
On x86-64 with GCC 14.2.1:
zim_Random_Randomizer_getBytes goes from 514 to 418 bytes
zim_Random_Randomizer_getBytesFromString goes from 750 to 676 bytes
This commit is contained in:
Niels Dossche 2025-05-05 19:12:39 +02:00 • committed by GitHub
parent be53902a13
commit a9b84f9425
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 7 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

14
ext/random/randomizer.c
View file

@ -297,7 +297,7 @@ PHP_METHOD(Random_Randomizer, getBytes)
while (total_size + 8 <= length) {
result = engine.algo->generate(engine.state);
if (EG(exception)) {
zend_string_free(retval);
zend_string_efree(retval);
RETURN_THROWS();
}
@ -326,7 +326,7 @@ PHP_METHOD(Random_Randomizer, getBytes)
while (total_size < length) {
result = engine.algo->generate(engine.state);
if (EG(exception)) {
zend_string_free(retval);
zend_string_efree(retval);
RETURN_THROWS();
}
@ -342,7 +342,7 @@ PHP_METHOD(Random_Randomizer, getBytes)
}
ZSTR_VAL(retval)[length] = '\0';
RETURN_STR(retval);
RETURN_NEW_STR(retval);
}
/* }}} */
@ -451,7 +451,7 @@ PHP_METHOD(Random_Randomizer, getBytesFromString)
uint64_t offset = engine.algo->range(engine.state, 0, max_offset);
if (EG(exception)) {
zend_string_free(retval);
zend_string_efree(retval);
RETURN_THROWS();
}
@ -473,7 +473,7 @@ PHP_METHOD(Random_Randomizer, getBytesFromString)
while (total_size < length) {
php_random_result result = engine.algo->generate(engine.state);
if (EG(exception)) {
zend_string_free(retval);
zend_string_efree(retval);
RETURN_THROWS();
}
@ -484,7 +484,7 @@ PHP_METHOD(Random_Randomizer, getBytesFromString)
if (offset > max_offset) {
if (++failures > PHP_RANDOM_RANGE_ATTEMPTS) {
zend_string_free(retval);
zend_string_efree(retval);
zend_throw_error(random_ce_Random_BrokenRandomEngineError, "Failed to generate an acceptable random number in %d attempts", PHP_RANDOM_RANGE_ATTEMPTS);
RETURN_THROWS();
}
@ -503,7 +503,7 @@ PHP_METHOD(Random_Randomizer, getBytesFromString)
}
ZSTR_VAL(retval)[length] = '\0';
RETURN_STR(retval);
RETURN_NEW_STR(retval);
}
/* }}} */