From 73f222d722460bebb98a1d2f11f891eefe4defde Mon Sep 17 00:00:00 2001 From: Dmitry Stogov Date: Thu, 24 Jan 2019 13:06:36 +0300 Subject: [PATCH] Fixed bug #77494 (Disabling class causes segfault on member access) --- NEWS | 2 ++ Zend/tests/bug77494.phpt | 16 ++++++++++++++++ Zend/zend_API.c | 11 +++++++++++ 3 files changed, 29 insertions(+) create mode 100644 Zend/tests/bug77494.phpt diff --git a/NEWS b/NEWS index 928cd54e2cc..dbf4216bb52 100644 --- a/NEWS +++ b/NEWS @@ -4,6 +4,8 @@ PHP NEWS - Core: . Fixed bug #77339 (__callStatic may get incorrect arguments). (Dmitry) + . Fixed bug #77494 (Disabling class causes segfault on member access). + (Dmitry) - Curl: . Fixed bug #76675 (Segfault with H2 server push). (Pedro Magalhães) diff --git a/Zend/tests/bug77494.phpt b/Zend/tests/bug77494.phpt new file mode 100644 index 00000000000..1793f6b219d --- /dev/null +++ b/Zend/tests/bug77494.phpt @@ -0,0 +1,16 @@ +--TEST-- +Bug #77494 (Disabling class causes segfault on member access) +--SKIPIF-- + +--INI-- +disable_classes=CURLFile +--FILE-- +name); +?> +--EXPECTF-- +Warning: CURLFile() has been disabled for security reasons in %sbug77494.php on line 2 + +Notice: Undefined property: CURLFile::$name in %sbug77494.php on line 3 +NULL diff --git a/Zend/zend_API.c b/Zend/zend_API.c index 600520552c5..d4b1502734f 100644 --- a/Zend/zend_API.c +++ b/Zend/zend_API.c @@ -2855,6 +2855,17 @@ static zend_object *display_disabled_class(zend_class_entry *class_type) /* {{{ zend_object *intern; intern = zend_objects_new(class_type); + + /* Initialize default properties */ + if (EXPECTED(class_type->default_properties_count != 0)) { + zval *p = intern->properties_table; + zval *end = p + class_type->default_properties_count; + do { + ZVAL_UNDEF(p); + p++; + } while (p != end); + } + zend_error(E_WARNING, "%s() has been disabled for security reasons", ZSTR_VAL(class_type->name)); return intern; }