From 2cd9233e42a68267d544bd15373521b7d531da6b Mon Sep 17 00:00:00 2001 From: Ilija Tovilo Date: Thu, 7 Aug 2025 13:54:55 +0200 Subject: [PATCH] Fix ERROR_CODE handling in COMMUNITY build We need || because a non-0 return from the application aborts the execution of the job. --- .github/workflows/nightly.yml | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/.github/workflows/nightly.yml b/.github/workflows/nightly.yml index b2846da496e..513ade4a710 100644 --- a/.github/workflows/nightly.yml +++ b/.github/workflows/nightly.yml @@ -570,8 +570,8 @@ jobs: cd "amphp-$repository" git rev-parse HEAD php /usr/bin/composer install --no-progress --ignore-platform-req=php+ - vendor/bin/phpunit - EXIT_CODE=$? + EXIT_CODE=0 + vendor/bin/phpunit || EXIT_CODE=$? echo -e "\n::endgroup::" if [ ${EXIT_CODE:-0} -gt 128 ]; then X=1; @@ -604,8 +604,8 @@ jobs: cd "reactphp-$repository" git rev-parse HEAD php /usr/bin/composer install --no-progress --ignore-platform-req=php+ - vendor/bin/phpunit - EXIT_CODE=$? + EXIT_CODE=0 + vendor/bin/phpunit || EXIT_CODE=$? echo -e "\n::endgroup::" if [ $[EXIT_CODE:-0} -gt 128 ]; then X=1; @@ -641,8 +641,8 @@ jobs: X=0 for component in $(find src/Symfony -mindepth 2 -type f -name phpunit.xml.dist -printf '%h\n'); do echo "::group::$component" - php ./phpunit $component --exclude-group tty --exclude-group benchmark --exclude-group intl-data --exclude-group transient --exclude-group skip - EXIT_CODE=$? + EXIT_CODE=0 + php ./phpunit $component --exclude-group tty --exclude-group benchmark --exclude-group intl-data --exclude-group transient --exclude-group skip || EXIT_CODE=$? echo -e "\n::endgroup::" if [ ${EXIT_CODE:-0} -gt 128 ]; then X=1;