archive/php-src
1
0
Fork 0
mirror of https://github.com/php/php-src.git synced 2025-08-15 21:48:51 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

Drop misleading comments about undefined behavior (GH-17532)

Browse source 
There is no undefined behavior here.  If `BitScan*()` returns zero, the
value written to the first parameter is undefined, but we return a
reasonable value.
This commit is contained in:
Christoph M. Becker 2025-01-26 22:50:52 +01:00 • committed by GitHub
parent d6c6675bfe
commit ab996934eb
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 0 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Zend/zend_bitset.h
View file

@ -60,7 +60,6 @@ ZEND_ATTRIBUTE_CONST static zend_always_inline int zend_ulong_ntz(zend_ulong num
#else #else
if (!BitScanForward(&index, num)) { if (!BitScanForward(&index, num)) {
#endif #endif
/* undefined behavior */
return SIZEOF_ZEND_LONG * 8; return SIZEOF_ZEND_LONG * 8;
} }
@ -98,7 +97,6 @@ ZEND_ATTRIBUTE_CONST static zend_always_inline int zend_ulong_nlz(zend_ulong num
#else #else
if (!BitScanReverse(&index, num)) { if (!BitScanReverse(&index, num)) {
#endif #endif
/* undefined behavior */
return SIZEOF_ZEND_LONG * 8; return SIZEOF_ZEND_LONG * 8;
} }