Fix GH-11141: Could not open input file: should be sent to stderr

I grepped for php_printf cases in main/ and sapi/ and converted the
cases which clearly indicate errors to fprintf(stderr, ...), like
suggested in the linked issue.

Closes GH-11163.
This commit is contained in:
Niels Dossche 2023-04-29 21:28:03 +02:00 committed by nielsdos
parent 42aaac3525
commit ac5920f92b
8 changed files with 17 additions and 13 deletions

View file

@ -2107,7 +2107,7 @@ zend_result php_module_startup(sapi_module_struct *sf, zend_module_entry *additi
/* start up winsock services */
if (WSAStartup(wVersionRequested, &wsaData) != 0) {
php_printf("\nwinsock.dll unusable. %d\n", WSAGetLastError());
fprintf(stderr, "\nwinsock.dll unusable. %d\n", WSAGetLastError());
return FAILURE;
}
php_win32_signal_ctrl_handler_init();
@ -2166,7 +2166,7 @@ zend_result php_module_startup(sapi_module_struct *sf, zend_module_entry *additi
* (this uses configuration parameters from php.ini)
*/
if (php_init_stream_wrappers(module_number) == FAILURE) {
php_printf("PHP: Unable to initialize stream url wrappers.\n");
fprintf(stderr, "PHP: Unable to initialize stream url wrappers.\n");
return FAILURE;
}
@ -2180,7 +2180,7 @@ zend_result php_module_startup(sapi_module_struct *sf, zend_module_entry *additi
/* startup extensions statically compiled in */
if (php_register_internal_extensions_func() == FAILURE) {
php_printf("Unable to start builtin modules\n");
fprintf(stderr, "Unable to start builtin modules\n");
return FAILURE;
}