archive/php-src
1
0
Fork 0
mirror of https://github.com/php/php-src.git synced 2025-08-15 13:38:49 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

Fix GH-9905: constant() behaves inconsistent when class is undefined

Browse source 
Directly referring to a constant of an undefined throws an exception;
there is not much point in `constant()` raising a fatal error in this
case.

Closes GH-9907.
This commit is contained in:
Christoph M. Becker 2022-11-08 17:13:35 +01:00
parent e1c52d1a7c
commit b2186ca7c4
No known key found for this signature in database
GPG key ID: D66C9593118BCCB6
4 changed files with 17 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

3
NEWS
View file

@ -2,6 +2,9 @@ PHP NEWS
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
?? ??? ????, PHP 8.1.14
- Core:
. Fixed bug GH-9905 (constant() behaves inconsistent when class is undefined).
(cmb)
24 Nov 2022, PHP 8.1.13

2
ext/standard/basic_functions.c
View file

@ -589,7 +589,7 @@ PHP_FUNCTION(constant)
ZEND_PARSE_PARAMETERS_END();
scope = zend_get_executed_scope();
c = zend_get_constant_ex(const_name, scope, 0);
c = zend_get_constant_ex(const_name, scope, ZEND_FETCH_CLASS_EXCEPTION);
if (!c) {
RETURN_THROWS();
}

12
ext/standard/tests/general_functions/gh9905.phpt Normal file
View file

@ -0,0 +1,12 @@
--TEST--
GH-9905 (constant() behaves inconsistent when class is undefined)
--FILE--
<?php
try {
\constant("\NonExistantClass::non_existant_constant");
} catch (\Throwable|\Error|\Exception $e) {
echo($e->getMessage());
}
?>
--EXPECT--
Class "NonExistantClass" not found

3
tests/lang/bug44827.phpt
View file

@ -21,5 +21,4 @@ try {
?>
--EXPECTF--
define(): Argument #1 ($constant_name) cannot be a class constant
Fatal error: Class "" not found in %s on line %d
Class "" not found